From: Mingming Cao <cmm@us.ibm.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-ext4@vger.kernel.org
Subject: Re: [RFC PATCH] ext4: Use page_mkwrite vma_operations to get mmap write notification.
Date: Wed, 05 Mar 2008 15:37:18 -0800 [thread overview]
Message-ID: <1204760238.3713.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20080305232927.GC18188@mit.edu>
On Wed, 2008-03-05 at 18:29 -0500, Theodore Tso wrote:
> On Tue, Mar 04, 2008 at 04:45:51PM -0800, Mingming Cao wrote:
> > > + /* FIXME!! should we take inode->i_mutex ? Currently we can't because
> > > + * it has a circular locking dependency with DIO. But migrate expect
> > > + * i_mutex to ensure no i_data changes
>
> Should I worry that we have something in the stable part of the patch
> queue with this FIXME!! comment? :-)
>
I think this comment could be moved to the migration.c. We can't take
i_mutex on mapped IO path. The i_data_mutex is the lock that should
protect the i_data concurrent changes, which is currently mapped IO
used. The race with migration could be addressed in migration instead of
here. I propose we drop this comment for now.
Mingming
next prev parent reply other threads:[~2008-03-05 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 12:42 [RFC PATCH] ext4: Use page_mkwrite vma_operations to get mmap write notification Aneesh Kumar K.V
2008-03-05 0:45 ` Mingming Cao
2008-03-05 23:29 ` Theodore Tso
2008-03-05 23:37 ` Mingming Cao [this message]
2008-03-05 23:59 ` Theodore Tso
-- strict thread matches above, loose matches on Subject: below --
2008-02-28 18:05 [RFC][PATCH] " Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204760238.3713.4.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.