Re: [PATCH 1/2] tkip: remove unused function, other cleanups

[Harvey Harrison <harvey.harrison@gmail.com>]

On Sat, 2008-03-08 at 07:52 +0100, Johannes Berg wrote:
> > -static inline u16 tkip_S(u16 val)
> > +static u16 tkip_S(u16 val)
> >  {
> > -	u16 a = tkip_sbox[Hi8(val)];
> > -
> > -	return tkip_sbox[Lo8(val)] ^ Hi8(a) ^ (Lo8(a) << 8);
> > +	return tkip_sbox[val & 0xff] ^ __swab16(tkip_sbox[val >> 8]);
> 
> What's wrong with using the non-underscored versions? This is pure
> kernel code...

That was a thinko on my part, I resent this in a 5-patch series shortly
thereafter without the underscores (the alignment problems you noted in
2/2 still remain).

Thanks for the comments.

Harvey