From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/5] mac80211: use kernel-provided bit rotation/byteordering
Date: Tue, 11 Mar 2008 09:17:16 -0700 [thread overview]
Message-ID: <1205252236.22317.0.camel@brick> (raw)
In-Reply-To: <1205251904.6387.50.camel@johannes.berg>
On Tue, 2008-03-11 at 17:11 +0100, Johannes Berg wrote:
> > include/linux/bitops.h | 40 ++++++++++++++++++++++++++++++++++++++++
>
> > +++ b/include/linux/bitops.h
> > @@ -65,6 +65,46 @@ static inline __u32 ror32(__u32 word, unsigned int shift)
> > return (word >> shift) | (word << (32 - shift));
> > }
> >
> > +/**
> > + * rol16 - rotate a 16-bit value left
> > + * @word: value to rotate
> > + * @shift: bits to roll
> > + */
> > +static inline __u16 rol16(__u16 word, unsigned int shift)
>
> I don't think we can take that via wireless, and I think architectures
> should be able to override this if they can optimise it (though the
> compiler might be good enough...)
OK, I'll get the common parts through Andrew and once that's in I'll
resubmit the wireless parts.
Harvey
prev parent reply other threads:[~2008-03-11 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 9:22 [PATCH 1/5] mac80211: use kernel-provided bit rotation/byteordering Harvey Harrison
2008-03-11 16:11 ` Johannes Berg
2008-03-11 16:17 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205252236.22317.0.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.