From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
heiko.carstens@de.ibm.com
Subject: Re: [patch 03/10] sched: add exported arch_reinit_sched_domains() to header file.
Date: Thu, 13 Mar 2008 10:48:52 +0100 [thread overview]
Message-ID: <1205401732.26537.43.camel@localhost> (raw)
In-Reply-To: <20080312160328.50cecd7f.akpm@linux-foundation.org>
On Wed, 2008-03-12 at 16:03 -0700, Andrew Morton wrote:
> > +#if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT)
> > +extern int arch_reinit_sched_domains(void);
> > +#endif
>
> I tend to recommend that the ifdefs be omitted here.
>
> It has the downside that the build will then fail at link-time rather than
> at compile-time, but I haven't seen anyone complain about that.
Ok, I've removed the #if.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-03-13 9:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 17:31 [patch 00/10] System z10 patches Martin Schwidefsky
2008-03-12 17:31 ` [patch 01/10] Add new fields for System z10 to /proc/sysinfo Martin Schwidefsky
2008-03-12 17:57 ` Josef 'Jeff' Sipek
2008-03-13 10:02 ` Martin Schwidefsky
2008-03-12 17:31 ` [patch 02/10] Export stfle Martin Schwidefsky
2008-03-12 17:31 ` [patch 03/10] sched: add exported arch_reinit_sched_domains() to header file Martin Schwidefsky
2008-03-12 23:03 ` Andrew Morton
2008-03-12 23:03 ` Andrew Morton
2008-03-13 9:48 ` Martin Schwidefsky [this message]
2008-03-21 12:29 ` Ingo Molnar
2008-03-12 17:31 ` [patch 04/10] sched: Add arch_update_cpu_topology hook Martin Schwidefsky
2008-03-21 12:30 ` Ingo Molnar
2008-03-12 17:32 ` [patch 05/10] cpu topology: convert siblings_show macro to accept non-lvalues Martin Schwidefsky
2008-03-12 17:32 ` [patch 06/10] cpu topology support for s390 Martin Schwidefsky
2008-03-12 23:11 ` Andrew Morton
2008-03-12 23:11 ` Andrew Morton
2008-03-13 12:28 ` Martin Schwidefsky
2008-03-13 22:40 ` Heiko Carstens
2008-03-12 17:32 ` [patch 07/10] Vertical cpu management Martin Schwidefsky
2008-03-12 17:32 ` [patch 08/10] Add missing TLB flush to hugetlb_cow() Martin Schwidefsky
2008-03-12 17:32 ` [patch 09/10] Hugetlb common code update for System z Martin Schwidefsky
2008-03-12 17:51 ` Dave Hansen
2008-03-12 23:18 ` Gerald Schaefer
2008-03-12 23:43 ` Andrew Morton
2008-03-13 17:49 ` Gerald Schaefer
2008-03-28 14:05 ` Gerald Schaefer
2008-03-28 14:06 ` Ingo Molnar
2008-03-28 14:33 ` Gerald Schaefer
2008-03-28 15:53 ` Martin Schwidefsky
2008-03-28 16:03 ` Ingo Molnar
2008-03-12 17:32 ` [patch 10/10] System z large page support Martin Schwidefsky
2008-03-12 17:52 ` Dave Hansen
2008-03-12 22:14 ` Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205401732.26537.43.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.