From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [patch 01/10] Add new fields for System z10 to /proc/sysinfo From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com In-Reply-To: <20080312175751.GB10653@josefsipek.net> References: <20080312173155.703966894@de.ibm.com> <20080312173216.213008370@de.ibm.com> <20080312175751.GB10653@josefsipek.net> Content-Type: text/plain Date: Thu, 13 Mar 2008 11:02:55 +0100 Message-Id: <1205402575.26537.46.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Josef 'Jeff' Sipek Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org List-ID: On Wed, 2008-03-12 at 13:57 -0400, Josef 'Jeff' Sipek wrote: > > Index: quilt-2.6/drivers/s390/sysinfo.c > > =================================================================== > > --- quilt-2.6.orig/drivers/s390/sysinfo.c > > +++ quilt-2.6/drivers/s390/sysinfo.c > > @@ -26,6 +26,11 @@ struct sysinfo_1_1_1 { > > char sequence[16]; > > char plant[4]; > > char model[16]; > > + char model_perm_cap[16]; > > + char model_temp_cap[16]; > > + char model_cap_rating[4]; > > + char model_perm_cap_rating[4]; > > + char model_temp_cap_rating[4]; > > }; > > I'd try to be safer, and make the struct __attribute__((packed))... Hmm, that would be true for all sysinfo typedefs. The automatic alignment does the right thing though. Don't know if its worth the effort - at least until you get bitten for the first time ;-) -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.