All of lore.kernel.org
 help / color / mirror / Atom feed
From: Girish Shilamkar <Girish.Shilamkar@Sun.COM>
To: Theodore Tso <tytso@mit.edu>
Cc: Ext4 Mailing List <linux-ext4@vger.kernel.org>
Subject: Convert between journal features and strings
Date: Fri, 14 Mar 2008 23:59:29 +0530	[thread overview]
Message-ID: <1205519369.3465.23.camel@alpha.linsyssoft.com> (raw)

Hi Ted,
	e2p_string2feature() and e2p_feature2string() can operate on ext2/3/4
features list as there is only one struct feature feature_list[] and no
corresponding journal features list. 
After introducing journal_checksum and journal_async_commit features, we
needed to display the features using debugfs which does it through the
two e2p_* functions. A new struct feature jrnl_feature_list[] was added.
The e2p_* functions were passed an additional argument so it can decide
which feature list to use.
Change in the APIs of e2p_* functions might not be acceptable so we have
an option to either make e2p_feature2string2() function or add
a new e2p_jnl_feature2string()

Would like to know what will be preferred e2p_feature2string2() or
e2p_jnl_feature2string() ?

Thanks,
Girish




             reply	other threads:[~2008-03-14 18:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 18:29 Girish Shilamkar [this message]
2008-03-14 20:41 ` Convert between journal features and strings Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205519369.3465.23.camel@alpha.linsyssoft.com \
    --to=girish.shilamkar@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.