All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <johnstul@us.ibm.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 4/5]  ntp.c code flow clenaups  (from Ingo)
Date: Fri, 14 Mar 2008 22:04:56 -0700	[thread overview]
Message-ID: <1205557496.6173.2.camel@jstultz-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0803150551020.1791@scrub.home>


On Sat, 2008-03-15 at 05:52 +0100, Roman Zippel wrote:
> Hi,
> 
> On Fri, 14 Mar 2008, john stultz wrote:
> 
> > +static inline void process_adjtimex_adj_offset(struct timex *txc, long sec)
> 
> Somewhat ugly name...

Oh, that's a mis-merge. Thanks for catching it. The name should have
been: process_adjtimex_modes().

process_adjtimex_adj_offset was basically the same as your
ntp_update_offset() function, so I killed it but grabbed the wrong
function name.

> From an userspace perspective it's the core of ntp_adjtime(), so I'd 
> prefer something close to that.

does process_adjtimex_modes(), or ntp_process_adjtimex_modes work for
you?

thanks
-john



  reply	other threads:[~2008-03-15  5:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15  4:04 [PATCH 0/5] time/ntp changes john stultz
2008-03-15  4:05 ` [PATCH 1/5] split clocksource adjustment from clockosurce mult john stultz
2008-03-15  4:06   ` [PATCH 2/5] introduce CLOCK_MONOTONIC_RAW john stultz
2008-03-15  4:10     ` [PATCH 3/5] cleanups ntp.c (from Ingo) john stultz
2008-03-15  4:12       ` [PATCH 4/5] ntp.c code flow clenaups " john stultz
2008-03-15  4:15         ` [PATCH 5/5] make more ntp values static john stultz
2008-03-15  5:09           ` Roman Zippel
2008-03-15  4:52         ` [PATCH 4/5] ntp.c code flow clenaups (from Ingo) Roman Zippel
2008-03-15  5:04           ` John Stultz [this message]
2008-03-15 12:39         ` Ingo Oeser
2008-03-15 17:24           ` Roman Zippel
2008-03-15  5:06       ` [PATCH 3/5] cleanups ntp.c " Roman Zippel
2008-03-15  9:32       ` Jörg-Volker Peetz
2008-03-15 17:23         ` Roman Zippel
2008-03-15  4:50     ` [PATCH 2/5] introduce CLOCK_MONOTONIC_RAW Roman Zippel
2008-03-18  2:03       ` john stultz
2008-03-18  2:27         ` john stultz
2008-03-26  3:41         ` Roman Zippel
2008-03-15  4:28   ` [PATCH 1/5] split clocksource adjustment from clockosurce mult Roman Zippel
2008-03-15  5:07     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205557496.6173.2.camel@jstultz-laptop \
    --to=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.