All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: hackbench regression since 2.6.25-rc
Date: Mon, 17 Mar 2008 11:05:36 +0800	[thread overview]
Message-ID: <1205723136.3215.300.camel@ymzhang> (raw)
In-Reply-To: <Pine.LNX.4.64.0803141356540.28115@schroedinger.engr.sgi.com>

On Fri, 2008-03-14 at 14:08 -0700, Christoph Lameter wrote:
> On Fri, 14 Mar 2008, Zhang, Yanmin wrote:
> 
> > > Ahhh... Okay those slabs did not change for 2.6.25-rc. Is there
> > > really a difference to 2.6.24?
> > As oprofile shows slub functions spend more than 80% cpu time, I would like
> > to focus on optimizing SLUB before going back to 2.6.24.
> 
> I thought you wanted to address a regression vs 2.6.24?
Initially I wanted to do so, but oprofile data showed both 2.6.24 and 2.6.25-rc
aren't good with hachbench on tigerton.

The slub_min_objects boot parameter could boost performance largely. So I think
we need optimize it before addressing the regression.

> 
> > kmalloc-512: No NUMA information available.
> > 
> > Slab Perf Counter       Alloc     Free %Al %Fr
> > --------------------------------------------------
> > Fastpath             55039159  5006829  68   6
> > Slowpath             24975754 75007769  31  93
> > Page Alloc              73840    73779   0   0
> > Add partial                 0 24341085   0  30
> > Remove partial       24267297    73779  30   0
> 
> ^^^ add partial/remove partial is likely the cause for 
> trouble here. 30% is unacceptably high. The larger allocs will reduce the 
> partial handling overhead. That is likely the effect that we see here.
> 
> > Refill 24975738
> 
> Duh refills at 50%? We could try to just switch to another slab instead of 
> reusing the existing one. May also affect the add/remove partial 
> situation.
> 
> 
> 


  parent reply	other threads:[~2008-03-17  3:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13  7:46 hackbench regression since 2.6.25-rc Zhang, Yanmin
2008-03-13  8:48 ` Andrew Morton
2008-03-13  9:28   ` Zhang, Yanmin
2008-03-13  9:52     ` Andrew Morton
2008-03-14  0:16     ` Christoph Lameter
2008-03-14  3:04       ` Zhang, Yanmin
2008-03-14  3:30         ` Zhang, Yanmin
2008-03-14  5:28           ` Zhang, Yanmin
2008-03-14  6:39             ` Christoph Lameter
2008-03-14  7:29               ` Zhang, Yanmin
2008-03-14 21:05                 ` Christoph Lameter
2008-03-14  6:34           ` Christoph Lameter
2008-03-14  7:23             ` Zhang, Yanmin
2008-03-14 21:06               ` Christoph Lameter
2008-03-17  7:50                 ` Zhang, Yanmin
2008-03-17 17:32                   ` Christoph Lameter
2008-03-18  3:28                     ` Zhang, Yanmin
2008-03-18  4:07                       ` Christoph Lameter
2008-03-14  6:32         ` Christoph Lameter
2008-03-14  7:14           ` Zhang, Yanmin
2008-03-14 21:08             ` Christoph Lameter
2008-03-15  0:15               ` Christoph Lameter
2008-03-17  3:35                 ` Zhang, Yanmin
2008-03-17 17:27                   ` Christoph Lameter
2008-03-17  3:05               ` Zhang, Yanmin [this message]
2008-03-13 15:14 ` Greg KH
2008-03-13 16:19   ` Randy Dunlap
2008-03-13 17:12     ` Greg KH
2008-03-14  0:50       ` Zhang, Yanmin
2008-03-14  5:01         ` Greg KH
2008-03-14  5:32           ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205723136.3215.300.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.