From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Jb70E-00052W-62
	for mharc-grub-devel@gnu.org; Mon, 17 Mar 2008 00:31:14 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jb70B-00052C-EJ
	for grub-devel@gnu.org; Mon, 17 Mar 2008 00:31:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jb706-00051F-7f
	for grub-devel@gnu.org; Mon, 17 Mar 2008 00:31:11 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jb706-000511-0U
	for grub-devel@gnu.org; Mon, 17 Mar 2008 00:31:06 -0400
Received: from c60.cesmail.net ([216.154.195.49])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <proski@gnu.org>) id 1Jb706-0003LN-44
	for grub-devel@gnu.org; Mon, 17 Mar 2008 00:31:06 -0400
Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81])
	by c60.cesmail.net with ESMTP; 17 Mar 2008 00:31:04 -0400
Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net
	[72.92.88.10])
	by relay.cesmail.net (Postfix) with ESMTP id 43773619058
	for <grub-devel@gnu.org>; Mon, 17 Mar 2008 00:31:04 -0400 (EDT)
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <ca0f59980803150034t5faf16dek227dffe156b3c9fc@mail.gmail.com>
References: <ca0f59980803050049x2d88e6a0tc10b6e91dadc7e26@mail.gmail.com>
	<ca0f59980803100853h67c73aeh8ffee0552e3fbc78@mail.gmail.com>
	<47D6F556.9040500@t-online.de>
	<ca0f59980803112226o24a602eyfafcb20151e7d37c@mail.gmail.com>
	<47D9B1CF.30801@t-online.de>
	<ca0f59980803132233l5d9f6b8em96e911bd7bca67b3@mail.gmail.com>
	<1205515683.2321.18.camel@dv>
	<ca0f59980803141258p1674d139v3a068a9d67983e8c@mail.gmail.com>
	<ca0f59980803141356t5effec06te488f5d29df6fce0@mail.gmail.com>
	<47DAE712.6070805@nic.fi>
	<ca0f59980803150034t5faf16dek227dffe156b3c9fc@mail.gmail.com>
Content-Type: text/plain
Date: Mon, 17 Mar 2008 00:31:03 -0400
Message-Id: <1205728263.2220.10.camel@dv>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) 
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] cdrom access patch
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Mar 2008 04:31:12 -0000

On Sat, 2008-03-15 at 15:34 +0800, Bean wrote:

> Ok, the new patch add (cd0) alias for cdrom device, the corresponding
> (hdN) is also present.
...
> 	(grub_biosdisk_call_hook): Only handle (hdN) device name.

I still don't understand this part.  Maybe you could split your patch
into smaller parts?

Suppose we hard drives at 0x80 and 0x82 and a CD at 0x90.  We can call
grub_biosdisk_get_cdinfo_int13_extension() and figure out that 0x90 is
the boot CD, so we call it (cd0).  Then we go through the drives and
call them (hd0), (hd1).

If it's OK to have an alias, why not suppress of hide the original name?

At what point do we need to use the _name_ to calculate the BIOS number?
Why cannot we simply store that number into some field?

-- 
Regards,
Pavel Roskin