From: Wei Wang2 <wei.wang2@amd.com>
To: "Han, Weidong" <weidong.han@intel.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Why call iommu_unmap_page() in set_p2m_entry()?
Date: Tue, 18 Mar 2008 18:29:45 +0100 [thread overview]
Message-ID: <1205861385.18682.47.camel@gran.amd.com> (raw)
In-Reply-To: <08DF4D958216244799FC84F3514D70F00124FB6E@pdsmsx415.ccr.corp.intel.com>
Hi Weidong,
Thanks for pointing it out. iommu_unmap_page() is not intended for
flushing all iotlb entries. As AMD-IOMMU also supports domain-selective
unmapping and I seem to find related functions in vtd code,I hope this
operation can also be generic. If not, I plan to put this into amd
specific functions called by domain destroy routines.
Wei
On Thu, 2008-03-13 at 14:28 +0100, Han, Weidong wrote:
> As my understanding, AMD IOMMU doesn't share its page tables with p2m
> table. So it needs call iommu_unmap_page() to free pages when shut
> down
> or destroy domain. Now iommu_unmap_page() is only called in
> set_p2m_entry(), I think it won't be executed when shut down or
> destroy
> domain. I'm not familiar with AMD IOMMU code, maybe I missed
> something.
> Can you explain why do that? Thanks!
>
> Randy (Weidong)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
>
next prev parent reply other threads:[~2008-03-18 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 13:28 Why call iommu_unmap_page() in set_p2m_entry()? Han, Weidong
2008-03-18 17:29 ` Wei Wang2 [this message]
2008-03-19 1:06 ` Han, Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205861385.18682.47.camel@gran.amd.com \
--to=wei.wang2@amd.com \
--cc=keir.fraser@eu.citrix.com \
--cc=weidong.han@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.