From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from zombie.ncsc.mil (zombie.ncsc.mil [144.51.88.131])
	by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with ESMTP id m2KCsLSl029879
	for <selinux@tycho.nsa.gov>; Thu, 20 Mar 2008 08:54:21 -0400
Received: from exchange.columbia.tresys.com (jazzdrum.ncsc.mil [144.51.5.7])
	by zombie.ncsc.mil (8.12.10/8.12.10) with SMTP id m2KCsHO6020036
	for <selinux@tycho.nsa.gov>; Thu, 20 Mar 2008 12:54:17 GMT
Subject: Re: [PATCH 1/5] REFPOL: Add new labeled networking permissions
From: "Christopher J. PeBenito" <cpebenito@tresys.com>
To: Paul Moore <paul.moore@hp.com>
Cc: selinux@tycho.nsa.gov
In-Reply-To: <200803191424.16724.paul.moore@hp.com>
References: <20080226184032.834798290@hp.com>
	 <20080226184404.862575664@hp.com> <1205932793.16113.42.camel@gorn>
	 <200803191424.16724.paul.moore@hp.com>
Content-Type: text/plain
Date: Thu, 20 Mar 2008 08:50:56 -0400
Message-Id: <1206017456.16113.86.camel@gorn>
Mime-Version: 1.0
Sender: owner-selinux@tycho.nsa.gov
List-Id: selinux@tycho.nsa.gov

On Wed, 2008-03-19 at 14:24 -0400, Paul Moore wrote:
> On Wednesday 19 March 2008 9:19:53 am Christopher J. PeBenito wrote:
> > On Tue, 2008-02-26 at 13:40 -0500, paul.moore@hp.com wrote:
> > > The 2.6.25 kernel will introduce a new set of labeled networking
> > > controls to SELinux and this patch makes the necessary changes to
> > > the Reference Policy to support unlabeled network traffic with the
> > > new controls.
> > >
> > > A description of the new/improved labeled networking controls was
> > > posted to the SELinux list back in early January 2008.
> > >
> > >  * http://marc.info/?l=selinux&m=119991234501200&w=2

> > > --- refpolicy_svn_repo.orig/policy/modules/kernel/corenetwork.if.in
> > > +++ refpolicy_svn_repo/policy/modules/kernel/corenetwork.if.in
> > > @@ -2380,6 +2392,27 @@ interface(`corenet_sendrecv_unlabeled_pa
> > >
> > >  ########################################
> > >  ## <summary>
> > > +##	Receive packets from an unlabeled peer.
> > > +## </summary>
> > > +## <desc>
> > > +##	<p>
> > > +##	Receive packets from an unlabeled peer,
> > > +##      these packets do not have any peer labeling
> > > +##      information present.
> > > +##	</p>
> > > +## </desc>
> > > +## <param name="domain">
> > > +##	<summary>
> > > +##	Domain allowed access.
> > > +##	</summary>
> > > +## </param>
> > > +#
> > > +interface(`corenet_recvfrom_unlabeled_peer',`
> > > +	kernel_recvfrom_unlabeled_peer($1)
> > > +')
> >
> > Seems unnecessary since it seems like it should be called from
> > corenet_(tcp|udp|raw)_recvfrom_unlabeled?
> 
> Okay, would you prefer to add kernel_recvfrom_unlabeled_peer() to 
> corenet_{tcp,udp,raw}_recvfrom_unlabeled() or simply add the new allow 
> rule to kernel_{tcp,udp,raw}_recvfrom_unlabeled()?

The latter seems the best choice.

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.