From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sam Ravnborg <sam@ravnborg.org>, Daniel Drake <dsd@gentoo.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH/RFC v3] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol
Date: Thu, 20 Mar 2008 12:09:11 -0700 [thread overview]
Message-ID: <1206040151.17059.10.camel@brick> (raw)
In-Reply-To: <1206038734.16475.153.camel@johannes.berg>
On Thu, 2008-03-20 at 19:45 +0100, Johannes Berg wrote:
> +For some ethernet hardware that cannot DMA to unaligned addresses like
> +4*n+2 or non-ethernet hardware, this can be a problem, and it is then
> +required to copy the incoming frame into an aligned buffer. Because this is
> +unnecessary on architectures that can do unaligned accesses, the code can be
> +made depend on CONFIG_HAVE_UNALIGNED_ACCESS_SUPPORT like so:
> +
> +#ifdef CONFIG_HAVE_UNALIGNED_ACCESS_SUPPORT
> + skb = original skb
> +#else
> + skb = copy skb
> +#endif
> +
Couldn't this just be made an inline in a networking header somewhere,
instead of ifdefs in the code?
Harvey
next prev parent reply other threads:[~2008-03-20 19:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:34 [PATCH/RFC] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol Johannes Berg
2008-03-20 14:39 ` Will Newton
2008-03-20 14:39 ` Will Newton
2008-03-20 14:58 ` Johannes Berg
2008-03-20 14:58 ` Johannes Berg
2008-03-20 18:13 ` Sam Ravnborg
2008-03-20 18:35 ` Johannes Berg
2008-03-20 18:35 ` Johannes Berg
2008-03-20 18:39 ` [PATCH/RFC v2] " Johannes Berg
2008-03-20 18:45 ` [PATCH/RFC v3] " Johannes Berg
2008-03-20 18:45 ` Johannes Berg
2008-03-20 19:09 ` Harvey Harrison [this message]
2008-03-20 19:12 ` Johannes Berg
2008-03-20 19:41 ` Sam Ravnborg
2008-03-20 19:41 ` Sam Ravnborg
2008-03-20 19:50 ` [PATCH/RFC v4] introduce HAVE_UNALIGNED_ACCESS_SUPPORT " Johannes Berg
2008-03-20 19:50 ` Johannes Berg
2008-03-21 8:45 ` Ingo Molnar
2008-03-20 21:13 ` [PATCH/RFC v2] introduce ARCH_CAN_UNALIGNED_ACCESS " David Miller
2008-03-20 21:21 ` Johannes Berg
2008-03-20 21:21 ` Johannes Berg
2008-03-20 21:27 ` David Miller
2008-03-20 21:27 ` David Miller
2008-03-20 22:03 ` John W. Linville
2008-03-20 22:03 ` John W. Linville
2008-03-20 22:10 ` David Miller
2008-03-20 22:10 ` David Miller
2008-03-25 14:11 ` [PATCH/RFC v5] introduce HAVE_EFFICIENT_UNALIGNED_ACCESS " Johannes Berg
2008-04-02 10:24 ` Johannes Berg
2008-04-02 10:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206040151.17059.10.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.