Re: [kvm-ppc-devel] [PATCH] kvmppc_relay: select required relay

[Hollis Blanchard <hollisb@us.ibm.com>]

On Thu, 2008-03-20 at 11:17 +0100, ehrhardt@linux.vnet.ibm.com wrote:
> Subject: [PATCH] kvmppc_relay: select required relay in config
> 
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> 
> When using the kvmppc_relay patch we need CONFIG_RELAY to compile.
> The simple solution to fold into our relay patch is in here which
> selects RELAY for us. If preferred we might implement as well a
> CONFIG_KVMPPC_TLBDEBUG which selects RELAY and ifdef's our code
> using relay elements.
> 
> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> ---
> 
>  Kconfig |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,6 +38,7 @@ config KVM_POWERPC_440
>  	tristate "KVM guest support for PowerPC 440"
>  	depends on KVM && 44x
>  	select KVM_POWERPC
> +	select RELAY 
>  	---help---
>  	  Provides support for KVM on 440 processors.

I'm worried about applying this now and then forgetting to change it
before submitting.

I think the right solution is the ifdef idea, but honestly I'm not even
sure I want to adhere to this naming scheme ("44x_tlb") and data format.
I'm also not sure it matters: it's supposed to be debug info only, so
not a stable ABI?

I think it might be better to call into 44x_tlb.c to create the channel
too, instead of sharing it between powerpc.c and 44x_tlb.c. At that
point the ifdefs become more localized too. Want to put together a patch
for that?

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel