From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jeu3r-0004dK-M1 for mharc-grub-devel@gnu.org; Thu, 27 Mar 2008 11:30:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jeu3i-0004XY-VY for grub-devel@gnu.org; Thu, 27 Mar 2008 11:30:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jeu3e-0004UQ-6X for grub-devel@gnu.org; Thu, 27 Mar 2008 11:30:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jeu3d-0004UD-KN for grub-devel@gnu.org; Thu, 27 Mar 2008 11:30:25 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Jeu3d-00013W-CD for grub-devel@gnu.org; Thu, 27 Mar 2008 11:30:25 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Mar 2008 11:30:23 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 1232C619058 for ; Thu, 27 Mar 2008 11:30:23 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20080326220948.xw0fmregqocog0s0@webmail.spamcop.net> Content-Type: text/plain Date: Thu, 27 Mar 2008 11:30:22 -0400 Message-Id: <1206631822.2380.2.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Native CD test results X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 15:30:34 -0000 On Thu, 2008-03-27 at 16:24 +0800, Bean wrote: > On Thu, Mar 27, 2008 at 10:09 AM, Pavel Roskin wrote: > > It turned out that the splash image called isolinux/splash.jpg is > > actually a png file. What's worse, GRUB won't use it because it's not > > 8-bit: > > > > $ identify splash.jpg > > splash.jpg PNG 640x480 640x480+0+0 DirectClass 16-bit 436.441kb > > It's quite easy to support 16-bit png, but i don't have one to test. > would you please send the image to me ? http://red-bean.com/proski/splash.png > > Once I had Fedora 9 installed, I tried to install the latest GRUB on > > it. But I would get a strange message: "Warning: syntax error > > (missing slash) in `'" > > > > It turned out that grub_parse_color_name_pair() was called from > > normal/menu.c, which didn't know a prototype for that function. Even > > though NULL was passed as the "name" argument, > > grub_parse_color_name_pair() would see some non-zero value. Adding > > the declaration to normal.h fixed the problem. > > I think this is caused by compile optimization. grub use -mregparm=3 > option, which means use register instead of stack to pass parameter. > When caller encounter a function without prototype, it use the c > calling convention, which conflict with callee. But i think gcc is not > to be blame here, because it just have no way to know better, we could > be calling a function in the c library, in which case, the standard > calling convention is the correct one. That makes sense. Thanks for the explanation. By the way, the fix for GRUB hanging when booting from a CD is not making any difference on the system where I discovered it initially. I need to look deeper. -- Regards, Pavel Roskin