From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JezvH-0004IY-RP for mharc-grub-devel@gnu.org; Thu, 27 Mar 2008 17:46:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JezvG-0004IP-LA for grub-devel@gnu.org; Thu, 27 Mar 2008 17:46:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JezvC-0004Ho-84 for grub-devel@gnu.org; Thu, 27 Mar 2008 17:46:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JezvC-0004Hj-27 for grub-devel@gnu.org; Thu, 27 Mar 2008 17:46:06 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JezvB-00011z-Ax for grub-devel@gnu.org; Thu, 27 Mar 2008 17:46:05 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Mar 2008 17:46:04 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id CFC01619058 for ; Thu, 27 Mar 2008 17:46:03 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1206650930.7377.16.camel@dv> References: <20080326220948.xw0fmregqocog0s0@webmail.spamcop.net> <1206631822.2380.2.camel@dv> <1206650930.7377.16.camel@dv> Content-Type: text/plain Date: Thu, 27 Mar 2008 17:46:03 -0400 Message-Id: <1206654363.10959.11.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Native CD test results X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 21:46:10 -0000 On Thu, 2008-03-27 at 16:48 -0400, Pavel Roskin wrote: > On Fri, 2008-03-28 at 04:25 +0800, Bean wrote: > > > This patch add support for 16-bit png. > > Thanks was quick! It's working for me. By the way, we should recognize images by their internal data, not by the filenames. As it stands now, the jpeg reader only supports files with ".jpeg" extension, not with ".jpg", which is more popular. And the error message is unclear if the extension is unknown. PNG begins with 89:50:4E:47, JPEG begins with FF:D8:FF:E0 and Targa can start with 00:00:01:01, 00:00:02:00, 00:00:03:00, 00:00:09:01, 00:00:0A:00 and 00:00:0B:00. If we have a good PNG support, we could drop Targa, which is rare and obsolete. -- Regards, Pavel Roskin