From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kewei@marvell.com
Cc: linux-scsi@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] mvsas: ATAPI LUN issue
Date: Thu, 27 Mar 2008 15:07:55 -0700 [thread overview]
Message-ID: <1206655675.3662.14.camel@localhost.localdomain> (raw)
In-Reply-To: <47E87F67.4080501@marvell.com>
On Tue, 2008-03-25 at 12:28 +0800, Ke Wei wrote:
> I found that sending REPORT_LUNS command to some DVD device will
> cause fis error and controller error record. As a result, scsi mid layer
> get some wrong LUNs. Also I can get some queer messages.
>
> scsi: host 12 channel 0 id 2 lun 0x30302e302f686f73 has a LUN larger
> than currently supported.
> scsi: host 12 channel 0 id 2 lun 0x7431322f706f7274 has a LUN larger
> than currently supported.
> scsi: host 12 channel 0 id 2 lun 0x2d31323a322f656e has a LUN larger
> than currently supported.
> ...
>
> The patch forced to clear the sg buffer of SATA response if FIS is
> error. But I suggest these codes should remove to the libsas module.
My first observation is that this isn't the correct approach: Most of
the CD/DVD simply respond with an error or the correct information. The
odd media changer will actually respond with real LUNs. Doing a blanket
erase of the REPORT LUN information will cause problems for media
changers.
I think the correct way to fix your problem is to blacklist the
particular CD. We have a BLIST_NOREPORTLUN for devices which behave
like this ... what are the INQUIRY strings?
James
prev parent reply other threads:[~2008-03-27 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 4:28 [PATCH] mvsas: ATAPI LUN issue Ke Wei
2008-03-27 22:07 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206655675.3662.14.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=jeff@garzik.org \
--cc=kewei@marvell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.