From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jf0HM-0006FM-GX for mharc-grub-devel@gnu.org; Thu, 27 Mar 2008 18:09:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jf0HK-0006Ea-Gt for grub-devel@gnu.org; Thu, 27 Mar 2008 18:08:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jf0HH-0006Ds-LR for grub-devel@gnu.org; Thu, 27 Mar 2008 18:08:57 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jf0HH-0006DZ-3u for grub-devel@gnu.org; Thu, 27 Mar 2008 18:08:55 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Jf0HG-0006n0-5v for grub-devel@gnu.org; Thu, 27 Mar 2008 18:08:54 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Mar 2008 18:08:53 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 31FEF619058 for ; Thu, 27 Mar 2008 18:08:53 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <47EC17BA.2020507@nic.fi> References: <20080326220948.xw0fmregqocog0s0@webmail.spamcop.net> <1206631822.2380.2.camel@dv> <1206650930.7377.16.camel@dv> <1206654363.10959.11.camel@dv> <47EC17BA.2020507@nic.fi> Content-Type: text/plain; charset=ISO-8859-1 Date: Thu, 27 Mar 2008 18:08:52 -0400 Message-Id: <1206655732.10959.18.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Native CD test results X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 22:08:58 -0000 On Thu, 2008-03-27 at 23:55 +0200, Vesa Jääskeläinen wrote: > Pavel Roskin wrote: > > On Thu, 2008-03-27 at 16:48 -0400, Pavel Roskin wrote: > >> On Fri, 2008-03-28 at 04:25 +0800, Bean wrote: > >> > >>> This patch add support for 16-bit png. > >> Thanks was quick! It's working for me. > > > > By the way, we should recognize images by their internal data, not by > > the filenames. As it stands now, the jpeg reader only supports files > > with ".jpeg" extension, not with ".jpg", which is more popular. And the > > error message is unclear if the extension is unknown. > > .jpg should of course be supported. Yes, I could not figure out why it wasn't working until I checked the sources. > But why we _should_ support others > (incorrectly named files) ? The name may be in upper case. Or maybe it's a compressed file ending with .gz that is being uncompressed on the fly. > I think file extension is good enough to > detect images... If someone makes incorrect extensions its their > problem... we just make sure our driver do not die at that... I don't insist, but GRUB traditionally gives its users power to force things in a specific way, for example, prevent automatic decompression or force loading a kernel as a FreeBSD kernel. Besides, users cannot rename images while in GRUB. -- Regards, Pavel Roskin