From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, akpm@linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@redhat.com, mpm@selenic.com
Subject: Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot
Date: Thu, 27 Mar 2008 17:02:37 -0700 [thread overview]
Message-ID: <1206662557.4849.112.camel@localhost> (raw)
In-Reply-To: <20080327.150456.39560267.davem@davemloft.net>
On Thu, 2008-03-27 at 15:04 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> > This will very likely negatively impact
> > high speed networking.
> Please run some tests before making claims like this.
I think this is the sort of change you might have argued
against accepting without performance testing not long ago.
> I might give you some slack in this area if you've
> been doing networking performance tuning for 10+ years
> but you haven't.
I've done some work in network performance testing.
cheers, Joe
next prev parent reply other threads:[~2008-03-28 0:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 12:37 [PATCH 0/7]: uninline some net related static inline in .h bloaters Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 2/7] [NET]: uninline skb_pull, " Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 3/7] [NET]: uninline dev_alloc_skb, " Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 4/7] [NET]: uninline skb_push, " Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 5/7] [NET]: uninline dst_release Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 6/7] [NET]: uninline skb_trim, de-bloats Ilpo Järvinen
2008-03-27 12:38 ` [PATCH 7/7] [SCTP]: Remove sctp_add_cmd_sf wrapper bloat Ilpo Järvinen
2008-03-28 0:54 ` David Miller
2008-03-28 0:54 ` [PATCH 6/7] [NET]: uninline skb_trim, de-bloats David Miller
2008-03-28 0:53 ` [PATCH 5/7] [NET]: uninline dst_release David Miller
2008-03-28 0:52 ` [PATCH 4/7] [NET]: uninline skb_push, de-bloats a lot David Miller
2008-03-27 23:36 ` [PATCH 3/7] [NET]: uninline dev_alloc_skb, " Denys Vlasenko
2008-03-28 0:52 ` David Miller
2008-03-28 1:42 ` Arnaldo Carvalho de Melo
2008-03-28 22:34 ` Denys Vlasenko
2008-03-28 22:57 ` David Miller
2008-03-29 4:52 ` Bill Fink
2008-03-28 0:51 ` David Miller
2008-03-27 19:10 ` [PATCH 1/7] [NET]: uninline skb_put, " Joe Perches
2008-03-27 22:04 ` David Miller
2008-03-28 0:02 ` Joe Perches [this message]
2008-03-28 0:04 ` David Miller
2008-03-28 0:11 ` Matt Mackall
2008-03-28 0:54 ` Joe Perches
2008-03-28 1:18 ` Matt Mackall
2008-03-28 19:56 ` Ilpo Järvinen
2008-03-28 0:43 ` David Miller
2008-03-28 0:54 ` [PATCH 0/7]: uninline some net related static inline in .h bloaters David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206662557.4849.112.camel@localhost \
--to=joe@perches.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.