From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hollis Blanchard <hollisb@us.ibm.com>
Date: Fri, 28 Mar 2008 16:10:45 +0000
Subject: Re: [kvm-ppc-devel] broken DTS syntax
Message-Id: <1206720645.5432.1.camel@basalt>
List-Id: <kvm-ppc.vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ppc@vger.kernel.org

On Fri, 2008-03-28 at 10:32 -0500, Jerone Young wrote:
> > paelzer@HeliosPrime
> ~/Desktop/KVM/ppc_port/kvm-userspace-vio/qemu/pc-bios $ dtc -I dts -O
> dtb -o bamboo.dtb2 bamboo.dts
> > DTC: dts->dtb  on file "bamboo.dts"
> > bamboo.dts:20 syntax error
> > FATAL ERROR: Couldn't read input tree
> > 
> > Is this correct/expected atm or do we have to fix something here
> before this goes upstream ?
> > 
> 
> This must be a dtc versioning issue. My version of dtc compiles the
> code
> fine without issue. But you may have a really older version. Hollis
> had
> spotted a bit of the same problem yesterday.
> 
> I am using dtc version:
> dtc -v
> Version: DTC 1.1.0-g2512a7eb
> 
> 
> Are you using an older version then this one. If so time for everyone
> to upgrade.

Interesting, I didn't realize the syntax had changed.

However, since it's just a matter of 4 characters, I think it's not too
much trouble to support the older DTC versions as well.

For reference, this is the fix:

diff -u b/qemu/pc-bios/bamboo.dts b/qemu/pc-bios/bamboo.dts
--- b/qemu/pc-bios/bamboo.dts
+++ b/qemu/pc-bios/bamboo.dts
@@ -17,8 +17,8 @@
        dcr-parent = <&/cpus/cpu@0>;
 
        aliases {
-               serial0 = &UART0;
-               serial1 = &UART1;   
+               serial0 = <&UART0>;
+               serial1 = <&UART1>;   
        };
 
        cpus {


-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel