Re: Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers.

[Alex Williamson <alex.williamson@hp.com>]

On Fri, 2008-03-28 at 22:37 +0000, Keir Fraser wrote:
> On 28/3/08 21:04, "Alex Williamson" <alex.williamson@hp.com> wrote:
> 
> > @@ -609,7 +609,7 @@ struct xen_ia64_opt_feature {
> > unsigned long cmd;  /* Which feature */
> > unsigned char on;  /* Switch feature on/off */
> > __anonymous_union {
> > -  __anonymous_struct {
> > +  struct {
> > /* The page protection bit mask of the pte.
> > * This will be or'ed with the pte. */
> > unsigned long pgprot;
> 
> I have no idea if it's the cause of this particular boot breakage, but I
> reckon that an anonymous union containing a single anonymous struct can be
> simplified. Or perhaps, if the union is there for stylistic reasons, a
> single extra field in the union would fix things?

   I toggled this one separately exactly for that reason, but it's not
the one.  I still haven't isolated a particular reason why it fails in a
test program, but I'll keep trying.  Thanks,

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.