All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <balrogg@gmail.com>
To: linux-omap@vger.kernel.org
Subject: [PATCH] Fix TUSB6010 ID register offsets.
Date: Sat, 29 Mar 2008 18:01:14 +0100	[thread overview]
Message-ID: <12068100744101-git-send-email-balrogg@gmail.com> (raw)

From: Andrzej Zaborowski <balrog@zabor.org>

I have no access to the docs for this chip but I'm pretty sure the current
address of the two DIDR1 registers is wrong because it's outside the
TUSB-specific register space.  The modified address in turn has a good
chance to be correct.

Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
---
 drivers/usb/musb/tusb6010.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
index bb25c3b..a40123d 100644
--- a/drivers/usb/musb/tusb6010.h
+++ b/drivers/usb/musb/tusb6010.h
@@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
 #define TUSB_PROD_TEST_RESET_VAL		0xa596
 #define TUSB_EP_FIFO(ep)			(TUSB_FIFO_BASE + (ep) * 0x20)
 
-#define TUSB_DIDR1_LO				0x1f8
-#define TUSB_DIDR1_HI				0x1fc
+#define TUSB_DIDR1_LO				(TUSB_FIFO_BASE + 0x1f8)
+#define TUSB_DIDR1_HI				(TUSB_FIFO_BASE + 0x1fc)
 #define		TUSB_DIDR1_HI_CHIP_REV(v)		(((v) >> 17) & 0xf)
 #define			TUSB_DIDR1_HI_REV_20		0
 #define			TUSB_DIDR1_HI_REV_30		1
-- 
1.5.3.4


             reply	other threads:[~2008-03-29 16:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29 17:01 Andrzej Zaborowski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-03-29 17:52 [PATCH] Fix TUSB6010 ID register offsets Andrzej Zaborowski
2008-03-31  7:58 ` Tony Lindgren
2008-03-31  8:58   ` Felipe Balbi
2008-03-31 12:52     ` andrzej zaborowski
2008-04-02 10:15 ` Felipe Balbi
2008-04-02 10:46   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12068100744101-git-send-email-balrogg@gmail.com \
    --to=balrogg@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.