All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-svn: remove redundant slashes from show-ignore
Date: Sat, 29 Mar 2008 16:47:46 -0700	[thread overview]
Message-ID: <1206834466.6543.30.camel@brick> (raw)
In-Reply-To: <20080329233717.GA16157@soma>

On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:
> Jonathan Scott Duff wrote:
> > Recently I tried "git svn showignore" on my parrot repository and it
> > failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> > $path has an extra / on the beginning (i.e., when it recurses, it
> > tries to get the props for "//apps" instead of "/apps").   I *think*
> > this is because $path is used in the recursive call rather than $p
> > (which seems to contain a properly transformed $path).  Anyway, I've
> > attached a patch that works for me and I think is generally the right
> > thing.
> 
> Patch-submitted-by: Jonathan Scott Duff

Shouldn't that be Signed-off-by?

Cheers,

Harvey

  reply	other threads:[~2008-03-29 23:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b762bfda0803291340ta70ee88k8d5d7c7e384e41e0@mail.gmail.com>
2008-03-29 23:37 ` [PATCH] git-svn: remove redundant slashes from show-ignore Eric Wong
2008-03-29 23:47   ` Harvey Harrison [this message]
2008-03-30  1:36     ` Eric Wong
2008-03-31  6:26       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206834466.6543.30.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.