From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@gmail.com>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH][NEWEMAC] Fix section mismatch warnings
Date: Sun, 30 Mar 2008 12:36:48 +1100 [thread overview]
Message-ID: <1206841008.10388.110.camel@pasglop> (raw)
In-Reply-To: <20080302163732.7c3af536@vader.jdub.homelinux.org>
On Sun, 2008-03-02 at 16:37 -0600, Josh Boyer wrote:
> This patch fixes several section mismatch warnings in the
> ibm_newemac driver similar to:
>
> WARNING: vmlinux.o(.devinit.text+0x3a04): Section mismatch in reference from the function emac_probe() to the function .devexit.text:tah_detach()
> The function __devinit emac_probe() references
> a function __devexit tah_detach().
>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Ack.
> ---
> drivers/net/ibm_newemac/core.c | 2 +-
> drivers/net/ibm_newemac/mal.c | 4 ++--
> drivers/net/ibm_newemac/rgmii.c | 2 +-
> drivers/net/ibm_newemac/tah.c | 2 +-
> drivers/net/ibm_newemac/zmii.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/core.c
> +++ linux-2.6/drivers/net/ibm_newemac/core.c
> @@ -2230,7 +2230,7 @@ static int __devinit emac_of_bus_notify(
> return 0;
> }
>
> -static struct notifier_block emac_of_bus_notifier = {
> +static struct notifier_block emac_of_bus_notifier __devinitdata = {
> .notifier_call = emac_of_bus_notify
> };
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/mal.c
> +++ linux-2.6/drivers/net/ibm_newemac/mal.c
> @@ -61,8 +61,8 @@ int __devinit mal_register_commac(struct
> return 0;
> }
>
> -void __devexit mal_unregister_commac(struct mal_instance *mal,
> - struct mal_commac *commac)
> +void mal_unregister_commac(struct mal_instance *mal,
> + struct mal_commac *commac)
> {
> unsigned long flags;
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/rgmii.c
> +++ linux-2.6/drivers/net/ibm_newemac/rgmii.c
> @@ -179,7 +179,7 @@ void rgmii_put_mdio(struct of_device *of
> mutex_unlock(&dev->lock);
> }
>
> -void __devexit rgmii_detach(struct of_device *ofdev, int input)
> +void rgmii_detach(struct of_device *ofdev, int input)
> {
> struct rgmii_instance *dev = dev_get_drvdata(&ofdev->dev);
> struct rgmii_regs __iomem *p = dev->base;
> --- linux-2.6.orig/drivers/net/ibm_newemac/tah.c
> +++ linux-2.6/drivers/net/ibm_newemac/tah.c
> @@ -35,7 +35,7 @@ int __devinit tah_attach(struct of_devic
> return 0;
> }
>
> -void __devexit tah_detach(struct of_device *ofdev, int channel)
> +void tah_detach(struct of_device *ofdev, int channel)
> {
> struct tah_instance *dev = dev_get_drvdata(&ofdev->dev);
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/zmii.c
> +++ linux-2.6/drivers/net/ibm_newemac/zmii.c
> @@ -189,7 +189,7 @@ void zmii_set_speed(struct of_device *of
> mutex_unlock(&dev->lock);
> }
>
> -void __devexit zmii_detach(struct of_device *ofdev, int input)
> +void zmii_detach(struct of_device *ofdev, int input)
> {
> struct zmii_instance *dev = dev_get_drvdata(&ofdev->dev);
>
prev parent reply other threads:[~2008-03-30 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 22:37 [PATCH][NEWEMAC] Fix section mismatch warnings Josh Boyer
2008-03-30 1:36 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206841008.10388.110.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.