All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Liu <r63238@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Merge code duplication in ata.h and	libata.h
Date: Mon, 31 Mar 2008 16:40:49 +0800	[thread overview]
Message-ID: <1206952849.3662.20.camel@localhost.localdomain> (raw)
In-Reply-To: <0JEB3vTG.1206954643.2020790.tor@localhost>

> >When I grep 'ATA_SECT_SIZE', I can *not* find any files including the
> >ATA_SECT_SIZE before the fsl_sata.c.
> 
> Well, the ata_piix driver for one uses it, but only includes ata.h. But
> that is the only one in the tree right now.
> 
> >> But the problem still remains, it is currently impossible to use both
> >> libata.h and ata.h.
> >
> >Why need use both them?
> >I believe the libata.h is enough.
> 
> Since my driver for the sil3114 uses "legacy mode" it uses a lot of the
> ata commands directly in PIO mode. These are defined in ata.h (Both in
> u-boot and Linux)

I believe the linux kernel happen at legacy mode same as you, but kernel
can handle the legacy mode, why you can not hanlde the legacy mode in u-
boot with same header file.

If you're using the I/O register descriptions and status register bits
in ata.h of u-boot. the kernel header have the same register/bit
definition. just like

ATA_REG_DATA
ATA_REG_ERR
...

ATA_BUSY
ATA_DRDY
...
ATA_ERR
ATA_SRST

  reply	other threads:[~2008-03-31  8:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31  6:35 [U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h Tor Krill
2008-03-31  6:45 ` Dave Liu
2008-03-31  8:20   ` Tor Krill
2008-03-31  7:37     ` Dave Liu
2008-03-31  9:10       ` Tor Krill
2008-03-31  8:40         ` Dave Liu [this message]
2008-03-31 10:45     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206952849.3662.20.camel@localhost.localdomain \
    --to=r63238@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.