All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] mac80211: use recent multicast table for all mesh multicast frames, not only broadcast
Date: Tue, 01 Apr 2008 09:41:13 -0700	[thread overview]
Message-ID: <1207068073.6388.10.camel@localhost> (raw)
In-Reply-To: <1207051222.5143.52.camel@johannes.berg>

On Tue, 2008-04-01 at 14:00 +0200, Johannes Berg wrote:
> Seems appropriate but I haven't checked the spec.

=EF=BB=BFThis was a bug, it was meant to be multicast from the begginin=
g.
Otherwise if a mesh node transmits a multicast (non-broadcast) frame an=
d
there are N mesh peers around it, it is going to be retransmitted
N^MESH_TTL times.


> On Mon, 2008-03-31 at 15:33 -0700, Luis Carlos Cobo wrote:
> > Signed-off-by: Luis Carlos Cobo <luisca@cozybit.com>
> > ---
> >  net/mac80211/rx.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >=20
> > diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> > index d9c6ed5..0ac6db5 100644
> > --- a/net/mac80211/rx.c
> > +++ b/net/mac80211/rx.c
> > @@ -433,7 +433,7 @@ ieee80211_rx_mesh_check(struct ieee80211_rx_dat=
a *rx)
> >  		}
> > =20
> >  	 } else if ((rx->fc & IEEE80211_FCTL_FTYPE) =3D=3D IEEE80211_FTYP=
E_DATA &&
> > -		    is_broadcast_ether_addr(hdr->addr1) &&
> > +		    is_multicast_ether_addr(hdr->addr1) &&
> >  		    mesh_rmc_check(hdr->addr4, msh_h_get(hdr, hdrlen), rx->dev))
> >  		return RX_DROP_MONITOR;
> >  #undef msh_h_get

--=20
Luis Carlos Cobo Rus       GnuPG ID: 44019B60
cozybit Inc.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-04-01 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31 22:33 [PATCH] mac80211: use recent multicast table for all mesh multicast frames, not only broadcast Luis Carlos Cobo
2008-04-01 12:00 ` Johannes Berg
2008-04-01 16:41   ` Luis Carlos Cobo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207068073.6388.10.camel@localhost \
    --to=luisca@cozybit.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.