All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: dhowells@redhat.com
Cc: linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	svens@stackframe.org
Subject: [PATCH] [PATCH] afs: add missing up_write() on return
Date: Wed,  2 Apr 2008 07:50:07 +0200	[thread overview]
Message-ID: <1207115407-7294-1-git-send-email-svens@stackframe.org> (raw)
In-Reply-To: <26826.1207085641@redhat.com>

if afs_cell_alloc() fails, afs_cells_sem doesn't get unlocked, which
leads to a deadlock. Unlock it before returning.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
 fs/afs/cell.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index 788865d..584bb0f 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -138,6 +138,7 @@ struct afs_cell *afs_cell_create(const char *name, char *vllist)
 	cell = afs_cell_alloc(name, vllist);
 	if (IS_ERR(cell)) {
 		_leave(" = %ld", PTR_ERR(cell));
+		up_write(&afs_cells_sem);
 		return cell;
 	}
 
-- 
1.5.4.5


      reply	other threads:[~2008-04-02  5:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 22:39 [AFS] prevent double cell registration Sven Schnelle
2008-03-25 17:23 ` David Howells
2008-03-25 17:27   ` Sven Schnelle
2008-03-25 19:05     ` David Howells
2008-04-01 20:44       ` Sven Schnelle
2008-04-01 21:34         ` David Howells
2008-04-02  5:50           ` Sven Schnelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207115407-7294-1-git-send-email-svens@stackframe.org \
    --to=svens@stackframe.org \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.