From: Peter Zijlstra <peterz@infradead.org>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Paul Jackson <pj@sgi.com>
Subject: Re: [PATCH 2/2] Customize sched domain via cpuset
Date: Wed, 02 Apr 2008 10:44:31 +0200 [thread overview]
Message-ID: <1207125871.8514.755.camel@twins> (raw)
In-Reply-To: <47F346A8.5000801@jp.fujitsu.com>
On Wed, 2008-04-02 at 17:41 +0900, Hidetoshi Seto wrote:
> Peter Zijlstra wrote:
> > On Tue, 2008-04-01 at 20:27 +0900, Hidetoshi Seto wrote:
> >> The implementation is here.
> >>
> >> - Add 2 new cpuset files:
> >> sched_wake_idle_far
> >> sched_balance_newidle_far
> >>
> >> - Modify partition_sched_domains() and build_sched_domains()
> >> to take flags parameter passed from cpuset.
> >>
> >> - Fill newidle_idx for node domains which currently unused but
> >> might be required for sched_balance_newidle_far.
> >
> > Just to be clear; the same effect can be had by poking into:
> >
> > /proc/sys/kernel/sched_domain/$cpu/$domain/flags
> >
> > but this interface you now propose gives a more stable interface in that
> > you'd have to re-do your setting after every cpuset change (admittedly
> > those are rare, but I see how it could be a nuisance).
>
> And the sysctl entry "sched_domain" is not available unless SCHED_DEBUG.
>
> So it is common sense that this sysctl is not open to public yet,
> and that the expected users are scheduler developers, Ingo and friends.
Ah, right, totally forgot about that :-)
> > Or do you actually add something that wasn't available through the
> > initial domain interface?
>
> At this time I have no idea, but it would be possible if there are
> something unreasonable on global system but acceptable on a part.
>
> In other words, we can invent other sched_* families which has special
> effect that "default scheduler" never have.
I was asking about this patch in specific, and the answer seems to be:
no, we don't add anything that wasn't available.
And yes, I see the possiblilties to extend this :-)
prev parent reply other threads:[~2008-04-02 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 11:27 [PATCH 2/2] Customize sched domain via cpuset Hidetoshi Seto
2008-04-01 11:51 ` Peter Zijlstra
2008-04-02 8:41 ` Hidetoshi Seto
2008-04-02 8:44 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207125871.8514.755.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.