From: Peter Zijlstra <peterz@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xfs-masters@oss.sgi.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: xfs_io "BUG: lock held when returning to user space!" on suspend
Date: Thu, 03 Apr 2008 16:07:00 +0200 [thread overview]
Message-ID: <1207231620.8514.829.camel@twins> (raw)
In-Reply-To: <1207230794.8514.825.camel@twins>
On Thu, 2008-04-03 at 15:53 +0200, Peter Zijlstra wrote:
> On Thu, 2008-04-03 at 07:57 +1000, David Chinner wrote:
> > On Wed, Apr 02, 2008 at 11:58:54AM -0700, Jeremy Fitzhardinge wrote:
> > > I'm getting this:
> > >
> > > ================================================
> > > [ BUG: lock held when returning to user space! ]
> > > ------------------------------------------------
> > > xfs_io/18796 is leaving the kernel with locks still held!
> > > 1 lock held by xfs_io/18796:
> > > #0: (&type->s_umount_key#19){----}, at: [<c048c9ac>] get_super+0x42/0x87
> > >
> > > when I suspend, possibly during an xfs-freeze. There don't seem to be any
> > > ill-effects.
> >
> > Yup, both the sb->s_umount and bdev->bd_mount_sem seaphores are held
> > across freeze_bdev()/thaw_bdev(), and they are issued via separate
> > ioctls generally from separate processes. Not great design, but not
> > a bug....
>
> Actually... we do consider that bugs.
http://lkml.org/lkml/2007/10/27/135
Where Linus says:
Definitely not a sane thing to do. It should use ref-counting and/or a
single bit to say "busy".
next prev parent reply other threads:[~2008-04-03 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 18:58 xfs_io "BUG: lock held when returning to user space!" on suspend Jeremy Fitzhardinge
2008-04-02 21:57 ` David Chinner
2008-04-03 13:53 ` Peter Zijlstra
2008-04-03 14:07 ` Peter Zijlstra [this message]
2008-04-04 1:50 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207231620.8514.829.camel@twins \
--to=peterz@infradead.org \
--cc=dgc@sgi.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.