All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Carsten Otte <cotte@de.ibm.com>
Cc: sfr@canb.auug.org.au,
	"kvm-devel@lists.sourceforge.net"
	<kvm-devel@lists.sourceforge.net>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Avi Kivity <avi@qumranet.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Olaf Schnapper <os@de.ibm.com>
Subject: Re: [PATCH 03/04] kvm-s390: Improve pgste accesses
Date: Fri, 04 Apr 2008 15:55:37 +0200	[thread overview]
Message-ID: <1207317337.15093.7.camel@localhost> (raw)
In-Reply-To: <1207314757.18908.20.camel@cotte.boeblingen.de.ibm.com>

On Fri, 2008-04-04 at 15:12 +0200, Carsten Otte wrote:
> Index: kvm/include/asm-s390/pgtable.h
> ===================================================================
> --- kvm.orig/include/asm-s390/pgtable.h
> +++ kvm/include/asm-s390/pgtable.h
> @@ -553,12 +553,12 @@ static inline void ptep_rcp_copy(pte_t *
> 
> skey = page_get_storage_key(page_to_phys(page));
> if (skey & _PAGE_CHANGED)
> - set_bit(RCP_GC_BIT, pgste);
> + set_bit_simple(RCP_GC_BIT, pgste);
> if (skey & _PAGE_REFERENCED)
> - set_bit(RCP_GR_BIT, pgste);
> - if (test_and_clear_bit(RCP_HC_BIT, pgste))
> + set_bit_simple(RCP_GR_BIT, pgste);
> + if (test_and_clear_bit_simple(RCP_HC_BIT, pgste))
> SetPageDirty(page);
> - if (test_and_clear_bit(RCP_HR_BIT, pgste))
> + if (test_and_clear_bit_simple(RCP_HR_BIT, pgste))
> SetPageReferenced(page);
> #endif
> }
> @@ -732,8 +732,8 @@ static inline int ptep_test_and_clear_yo
> young = ((page_get_storage_key(physpage) & _PAGE_REFERENCED) != 0);
> rcp_lock(ptep);
> if (young)
> - set_bit(RCP_GR_BIT, pgste);
> - young |= test_and_clear_bit(RCP_HR_BIT, pgste);
> + set_bit_simple(RCP_GR_BIT, pgste);
> + young |= test_and_clear_bit_simple(RCP_HR_BIT, pgste);
> rcp_unlock(ptep);
> return young;
> #endif

Major formatting accident ?

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  reply	other threads:[~2008-04-04 13:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1207314468.18908.12.camel@cotte.boeblingen.de.ibm.com>
2008-04-04 13:12 ` [PATCH 01/04] kvm-s390: Some codingstyle issues Carsten Otte
2008-04-04 13:12 ` [PATCH 02/04] kvm-s390: Fix incorrect return value Carsten Otte
2008-04-04 13:12 ` [PATCH 03/04] kvm-s390: Improve pgste accesses Carsten Otte
2008-04-04 13:55   ` Martin Schwidefsky [this message]
2008-04-04 14:01     ` Carsten Otte
2008-04-04 21:08   ` Avi Kivity
2008-04-04 13:12 ` [PATCH 04/04] kvm-s390: rename stfl to kvm_stfl Carsten Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207317337.15093.7.camel@localhost \
    --to=schwidefsky@de.ibm.com \
    --cc=avi@qumranet.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=os@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.