Re: [PATCH] Add Realtek 8187B support

[Pavel Roskin <proski@gnu.org>]

On Wed, 2008-04-09 at 14:36 -0300, Herton Ronaldo Krzesinski wrote:

> I run checkpatch.pl, I just didn't fixed these because they were lines already
> this way, my patch got these because I moved reset code common to rtl8187b
> and rtl8187 (new rtl8187_cmd_reset function) out of rtl8187_init_hw. Also I
> introduced some new ones, these lines are over 80 characters:
> rtl818x_iowrite8(priv, &priv->map->CONFIG3, reg | RTL818X_CONFIG3_ANAPARAM_WRITE);
> rtl818x_iowrite8(priv, &priv->map->EEPROM_CMD, RTL818X_EEPROM_CMD_CONFIG);
> 
> Should I fix all of these ocurrences in rtl8187b patch or in a new patch?

I feel bad that you have to deal with sloppy code left by others, but
these are the rules of the game.  I suggest that you do all cleanups
first as separate patches, and then the user-visible changes.  The only
exception is then your user visible changes replace the old code.

I could do some cleanups myself, but I think it would be easier for you
to do it at once rather than merge my patches.

Or maybe we should ask the existing maintainers to prepare a clean
playground for new contributors?  Michael?  Andrea?

-- 
Regards,
Pavel Roskin