From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261587AbUKCNmM (ORCPT ); Wed, 3 Nov 2004 08:42:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261595AbUKCNmM (ORCPT ); Wed, 3 Nov 2004 08:42:12 -0500 Received: from mx1.redhat.com ([66.187.233.31]:21416 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261587AbUKCNmK (ORCPT ); Wed, 3 Nov 2004 08:42:10 -0500 From: David Howells In-Reply-To: <20041103103927.GA18416@infradead.org> References: <20041103103927.GA18416@infradead.org> <20041102093440.GA5841@infradead.org> <76b4a884-2c3c-11d9-91a1-0002b3163499@redhat.com> <200411011930.iA1JULar023202@warthog.cambridge.redhat.com> <25541.1099411798@redhat.com> To: Christoph Hellwig Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH 7/14] FRV: GDB stub dependent additional BUG()'s User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Wed, 03 Nov 2004 13:41:52 +0000 Message-ID: <12079.1099489312@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > just put it in every arch. Or even better drop your gdbstub for now > and integrate it with the common kgdb code in -mm. Ummm... what common kgdb code? It seems to be almost all per-arch anyway. Besides, on this arch the gdbstub runs in a different CPU mode from the rest of the kernel, which makes life more interesting. > Because it's not fatal without your debugger, so it shouldn't magically > get fatal. If you think this is fatal convience Andrew to add a BUG() here. It could be made contingent on a debugger being attached rather than being a mandatory BUG. David