All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: cs044024@mnnit.ac.in
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: modifying CFS failure
Date: Sat, 12 Apr 2008 14:22:03 +0200	[thread overview]
Message-ID: <1208002923.7427.5.camel@twins> (raw)
In-Reply-To: <42423.210.212.49.15.1207972006.squirrel@mail.mnnit.ac.in>

Please provide it as a series of patches against sched-devel/latest.

Just plain AVL code and a huge modified CFS backport make it impossible
to tell what changed and why.

Which brings us to the question: _why_. That is, why are you trying to
replace the rb-tree with an avl tree? Just because the worst case depth
of the avl is slightly better than for an rb-tree, which can be offset
by the slightl more expesive balance operations.

I'm glad people are working on CFS - its an interesting piece of the
kernel after all, but provide it in a regular patch series, this is
impossible to work with, sorry.


  reply	other threads:[~2008-04-12 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12  3:46 modifying CFS failure cs044024
2008-04-12 12:22 ` Peter Zijlstra [this message]
2008-04-12 13:22   ` Willy Tarreau
2008-04-13 15:53   ` cs044024

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208002923.7427.5.camel@twins \
    --to=peterz@infradead.org \
    --cc=cs044024@mnnit.ac.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.