From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JlDCB-00023W-Sm for mharc-grub-devel@gnu.org; Sun, 13 Apr 2008 21:09:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JlDCA-00020M-7c for grub-devel@gnu.org; Sun, 13 Apr 2008 21:09:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JlDC8-0001wq-I0 for grub-devel@gnu.org; Sun, 13 Apr 2008 21:09:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JlDC8-0001wR-8J for grub-devel@gnu.org; Sun, 13 Apr 2008 21:09:16 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JlDC8-00060M-4Z for grub-devel@gnu.org; Sun, 13 Apr 2008 21:09:16 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 13 Apr 2008 21:09:12 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id CAFA3619058 for ; Sun, 13 Apr 2008 21:09:11 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080413110842.GB20737@thorin> References: <20080326220948.xw0fmregqocog0s0@webmail.spamcop.net> <20080413110842.GB20737@thorin> Content-Type: text/plain Date: Sun, 13 Apr 2008 21:09:11 -0400 Message-Id: <1208135351.5319.16.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Native CD test results X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2008 01:09:18 -0000 On Sun, 2008-04-13 at 13:08 +0200, Robert Millan wrote: > On Wed, Mar 26, 2008 at 10:09:48PM -0400, Pavel Roskin wrote: > > > > I was surprised to see that "ls" would not show partitions on the hard > > drives. It turns out the "pc" module wasn't loaded. Perhaps it > > should be preloaded, or maybe it would be autoloaded when a PC style > > partition table is detected. > > I think my last commit fixed that: > > * util/i386/pc/grub-mkrescue.in: Generate grub.cfg that loads needed > modules (including all partition maps), instead of preloading them. Yes, it's working now. > > Perhaps we should enable more warnings. Also, it would be great to > > make the build system less noisy by default, so that the warnings > > stand out as they should. And I'd like to be able to check GRUB with > > sparse one day. > > I would even go for -Werror mode. We cannot go there yet. There are some format string warnings that are hard to fix nicely. Sure, we can cast everything to long long and use "%llx" to be sure, but it doesn't look nice to me. There are some other warnings that need work. But we could use -Werror-implicit-function-declaration for the compilers that understand it. Missing declarations can cause some pretty weird errors. -- Regards, Pavel Roskin