From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
apw@shadowen.org, linux-mm@kvack.org
Subject: Re: [patch 17/19] Use kbuild.h instead of defining macros in asm-offsets.c
Date: Tue, 15 Apr 2008 10:14:04 +0200 [thread overview]
Message-ID: <1208247244.3664.5.camel@localhost> (raw)
In-Reply-To: <20080414221848.428938934@sgi.com>
On Mon, 2008-04-14 at 15:18 -0700, Christoph Lameter wrote:
> s390 has a strange marker in DEFINE. Undefine the DEFINE from kbuild.h and define
> it the way s390 wants it to preserve things as they were.
That is a leftover from the very first version of the asm-offsets code.
All the DEFINEs in arch/s390/kernel/asm-offsets.c have an empty third
argument, we never needed it.
> May be good if the arch maintainer could go over this and check if this workaround
> is really necessary.
No, the workaround can go. We can use the default macro if the DEFINE
lines get adapted: "s/,);/\);/"
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-15 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080414221808.269371488@sgi.com>
[not found] ` <20080414221846.735656759@sgi.com>
2008-04-14 22:22 ` [patch 10/19] blackfin: Use kbuild.h instead of defining macros in asm-macros.c Mike Frysinger
[not found] ` <20080414221848.428938934@sgi.com>
2008-04-15 8:14 ` Martin Schwidefsky [this message]
[not found] ` <20080414221846.967753424@sgi.com>
2008-04-15 9:55 ` [patch 11/19] frv: Use kbuild.h instead of defining macros in asm-offsets.c David Howells
2008-04-15 19:09 ` Christoph Lameter
[not found] ` <20080414221844.876647987@sgi.com>
2008-04-16 13:01 ` [patch 02/19] x86: Use kbuild.h Ingo Molnar
2008-04-16 14:10 ` Ingo Molnar
2008-04-16 17:44 ` Christoph Lameter
2008-04-16 19:15 ` Andrew Morton
2008-04-16 19:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208247244.3664.5.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.