From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JlqSF-00057W-Jr for mharc-grub-devel@gnu.org; Tue, 15 Apr 2008 15:04:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JlqSD-00056e-W8 for grub-devel@gnu.org; Tue, 15 Apr 2008 15:04:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JlqSC-000563-N2 for grub-devel@gnu.org; Tue, 15 Apr 2008 15:04:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JlqSC-00055u-Ch for grub-devel@gnu.org; Tue, 15 Apr 2008 15:04:28 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JlqSB-0008DH-Vv for grub-devel@gnu.org; Tue, 15 Apr 2008 15:04:28 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 15 Apr 2008 15:04:27 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id EB80761905A for ; Tue, 15 Apr 2008 15:04:26 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080415133501.GF21548@thorin> References: <1208212910.3971.53.camel@localhost.localdomain> <20080415133501.GF21548@thorin> Content-Type: text/plain Date: Tue, 15 Apr 2008 15:04:26 -0400 Message-Id: <1208286266.23118.6.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Preserve build IDs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2008 19:04:30 -0000 On Tue, 2008-04-15 at 15:35 +0200, Robert Millan wrote: > On Tue, Apr 15, 2008 at 12:41:50AM +0200, Lubomir Kundrak wrote: > > This will make Fedora packagers have good sleep. I think we discussed > > this already on the list. Rationale behind disabling build-ids > > completely was that it caused images to grow a lot. Correct solution is > > to disable it from images only and let it exists in elf files for > > debugging purposes. > > > > 2008-04-15 Lubomir Kundrak > > > > * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): take only .text > > section into account, newer toolchains generate unique build ids > > * configure.ac: remove the test for --build-id=none acceptance, > > we want build ids to bre preserved > > * genmk.rb: add -R .note.gnu.build-id to objcopy, so build id > > far from other sections don't cause the raw binary images grow > > size > > Looks good to me. Pavel will probably know better though. Looks good to me too. There is a bug in objcopy if it's used without stripping the build ID. But if we are stripping it, there should be no problem with it. -- Regards, Pavel Roskin