From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix file name transformations (mostly)
Date: Tue, 15 Apr 2008 15:19:59 -0400 [thread overview]
Message-ID: <1208287199.23118.18.camel@dv> (raw)
In-Reply-To: <1208211148.3971.38.camel@localhost.localdomain>
On Tue, 2008-04-15 at 00:12 +0200, Lubomir Kundrak wrote:
> Hi,
>
> Attaching the patch that fixes ./configure's --program-transform-name
> option. Tested with --program-transform-name=s,grub,grub2, quite
> extensively. Only one more modification is needed to completely support
> this -- define DEFAULT_DIRECTORY with -D option of the preprocessor
> instead of hardcoding in include/grub/util/misc.h. Should be fairly
> trivial though.
I would prefer if we don't rush with "program-transform-name" at the
expense of readability, but rather make other simplifications what would
have a similar effect. I think ${libdir}/grub should be given a name
(e.g. grublibdir) in configure.ac and substituted in the scripts.
As for /boot/grub, we are not installing anything there on "make
install". I don't think it should be transformed. But we could accept
a configuration option to change that directory.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-04-15 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 22:12 [PATCH] Fix file name transformations (mostly) Lubomir Kundrak
2008-04-15 13:33 ` Robert Millan
2008-04-17 11:47 ` Lubomir Kundrak
2008-04-15 19:19 ` Pavel Roskin [this message]
2008-04-17 11:49 ` Lubomir Kundrak
2008-04-17 19:20 ` Pavel Roskin
2008-04-17 20:07 ` Robert Millan
2008-04-18 6:41 ` Lubomir Kundrak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208287199.23118.18.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.