From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JmSal-0008Eb-Nm for mharc-grub-devel@gnu.org; Thu, 17 Apr 2008 07:47:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmSak-0008EN-KG for grub-devel@gnu.org; Thu, 17 Apr 2008 07:47:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmSai-0008Dv-1a for grub-devel@gnu.org; Thu, 17 Apr 2008 07:47:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmSah-0008Dr-Tj for grub-devel@gnu.org; Thu, 17 Apr 2008 07:47:47 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmSah-0004Nm-Df for grub-devel@gnu.org; Thu, 17 Apr 2008 07:47:47 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3HBlfvY015903 for ; Thu, 17 Apr 2008 07:47:41 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3HBlePs007266 for ; Thu, 17 Apr 2008 07:47:40 -0400 Received: from [10.34.1.17] (gopher.brq.redhat.com [10.34.1.17]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m3HBldbR030946 for ; Thu, 17 Apr 2008 07:47:39 -0400 From: Lubomir Kundrak To: The development of GRUB 2 In-Reply-To: <20080415133312.GE21548@thorin> References: <1208211148.3971.38.camel@localhost.localdomain> <20080415133312.GE21548@thorin> Content-Type: text/plain Organization: Red Hat Inc. Date: Thu, 17 Apr 2008 13:47:41 +0200 Message-Id: <1208432861.770.32.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix file name transformations (mostly) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2008 11:47:50 -0000 On Tue, 2008-04-15 at 15:33 +0200, Robert Millan wrote: > On Tue, Apr 15, 2008 at 12:12:28AM +0200, Lubomir Kundrak wrote: > > diff -urp grub-1.96.orig/util/update-grub.in grub-1.96/util/update-grub.in > > --- grub-1.96.orig/util/update-grub.in 2008-03-16 17:52:32.000000000 +0100 > > +++ grub-1.96/util/update-grub.in 2008-03-16 17:59:42.000000000 +0100 > > @@ -23,7 +23,7 @@ exec_prefix=@exec_prefix@ > > sbindir=@sbindir@ > > libdir=@libdir@ > > sysconfdir=@sysconfdir@ > > -grub_prefix=`echo /boot/grub | sed ${transform}` > > +grub_prefix=/boot/`echo /grub | sed ${transform}` > > Is the second slash intentional? No. > > --- grub-1.96.orig/util/update-grub_lib.in.transform 2008-03-23 11:46:14.000000000 +0100 > > +++ grub-1.96/util/update-grub_lib.in 2008-03-23 11:49:21.000000000 +0100 > > @@ -95,7 +95,8 @@ > > { > > # Prefer system path for space reasons (/boot/grub might be a very small > > # partition in case of OpenFirmware, etc). > > - for dir in ${pkgdatadir} /usr/share/grub /boot/grub ; do > > + for dir in ${pkgdatadir} ${pkgdatadir}/`echo grub | sed ${transform}` \ > > + /boot/`echo grub | sed ${transform}`; do > > I'd prefer is grub_prefix was defined here too (for readability). Yep, there's space for improvement. See Pavel's reply to that mail. Thanks, -- Lubomir Kundrak (Red Hat Security Response Team)