From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JmSc8-0001NL-OY for mharc-grub-devel@gnu.org; Thu, 17 Apr 2008 07:49:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmSc7-0001MA-KZ for grub-devel@gnu.org; Thu, 17 Apr 2008 07:49:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmSc4-0001J0-Vx for grub-devel@gnu.org; Thu, 17 Apr 2008 07:49:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmSc4-0001IY-Fh for grub-devel@gnu.org; Thu, 17 Apr 2008 07:49:12 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmSc4-0004iF-2B for grub-devel@gnu.org; Thu, 17 Apr 2008 07:49:12 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3HBnB88016656 for ; Thu, 17 Apr 2008 07:49:11 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3HBnAnE007785 for ; Thu, 17 Apr 2008 07:49:11 -0400 Received: from [10.34.1.17] (gopher.brq.redhat.com [10.34.1.17]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m3HBnAxu031074 for ; Thu, 17 Apr 2008 07:49:10 -0400 From: Lubomir Kundrak To: The development of GRUB 2 In-Reply-To: <1208287199.23118.18.camel@dv> References: <1208211148.3971.38.camel@localhost.localdomain> <1208287199.23118.18.camel@dv> Content-Type: text/plain Organization: Red Hat Inc. Date: Thu, 17 Apr 2008 13:49:12 +0200 Message-Id: <1208432952.770.35.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix file name transformations (mostly) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2008 11:49:16 -0000 On Tue, 2008-04-15 at 15:19 -0400, Pavel Roskin wrote: > On Tue, 2008-04-15 at 00:12 +0200, Lubomir Kundrak wrote: > > Hi, > > > > Attaching the patch that fixes ./configure's --program-transform-name > > option. Tested with --program-transform-name=s,grub,grub2, quite > > extensively. Only one more modification is needed to completely support > > this -- define DEFAULT_DIRECTORY with -D option of the preprocessor > > instead of hardcoding in include/grub/util/misc.h. Should be fairly > > trivial though. > > I would prefer if we don't rush with "program-transform-name" at the > expense of readability, but rather make other simplifications what would > have a similar effect. I think ${libdir}/grub should be given a name > (e.g. grublibdir) in configure.ac and substituted in the scripts. That makes sense. Another solution would be to have shell library to include by all scripts and define variables with substituted names there. > As for /boot/grub, we are not installing anything there on "make > install". I don't think it should be transformed. But we could accept > a configuration option to change that directory. We should have a sensible default that wouldn't clash with GRUB Legacy's default. Thanks, -- Lubomir Kundrak (Red Hat Security Response Team)