From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JmWYD-0007Uq-Fv for mharc-grub-devel@gnu.org; Thu, 17 Apr 2008 12:01:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmWYC-0007UV-53 for grub-devel@gnu.org; Thu, 17 Apr 2008 12:01:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmWYA-0007UB-6p for grub-devel@gnu.org; Thu, 17 Apr 2008 12:01:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmWY9-0007U6-Mu for grub-devel@gnu.org; Thu, 17 Apr 2008 12:01:25 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmWY9-0002qH-4w for grub-devel@gnu.org; Thu, 17 Apr 2008 12:01:25 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3HG1MLM001583 for ; Thu, 17 Apr 2008 12:01:22 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3HG1F5u018366 for ; Thu, 17 Apr 2008 12:01:21 -0400 Received: from [10.32.4.90] (vpn-4-90.str.redhat.com [10.32.4.90]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m3HG1ETp017950 for ; Thu, 17 Apr 2008 12:01:14 -0400 From: Lubomir Kundrak To: The development of GRUB 2 In-Reply-To: <200804151432.49014.Chris.Knadle@coredump.us> References: <1208211768.3971.44.camel@localhost.localdomain> <20080415132011.GC21548@thorin> <200804151432.49014.Chris.Knadle@coredump.us> Content-Type: text/plain Organization: Red Hat Inc. Date: Thu, 17 Apr 2008 18:01:16 +0200 Message-Id: <1208448076.770.68.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Extend the code to ignore junk files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2008 16:01:28 -0000 On Tue, 2008-04-15 at 14:32 -0400, Chris Knadle wrote: > On Tuesday 15 April 2008, Robert Millan wrote: > > On Tue, Apr 15, 2008 at 12:22:48AM +0200, Lubomir Kundrak wrote: > > > --- grub-1.96.orig/util/update-grub_lib.in 2008-04-15 00:16:12.000000000 > > > +0200 +++ grub-1.96/util/update-grub_lib.in 2008-04-15 00:15:04.000000000 > > > +0200 @@ -115,6 +115,8 @@ grub_file_is_not_garbage () > > > if test -f "$1" ; then > > > case "$1" in > > > *.dpkg-dist|*.dpkg-old|*.dpkg-tmp) return 1 ;; # debian dpkg > > > + *.rpmnew|*.rpmsave) return 1 ;; # Fedora rpm > > > + *.bak|*~|.*.swp) return 1 ;; # backup and swap files from > > > editors > > > > This has the side-effect that Linux images whose name ends with ~ are > > excluded, which is probably not that uncommon. E.g. > > /boot/vmlinuz-2.6.24.foobar~ > > > > Is this really what we want? Not uncommon; well -- I've never seen that, nor heard about if as being a custom -- but it might be just that have not seen enough. > I don't know of any localversion policy requiring that the last character > not be a tilde character. I think the localversion policy doesn't forbid the names ending with .dpkg-dist or .bak as well. > However, I can say that 'fakeroot make-kpkg > kernel_image' fails at the very last stage during making a .deb if the last > character in the localversion ends in a tilde. i.e. you can't build a > kernel "the Debian way" that has a localversion ending in a tilde. > > dpkg-gencontrol: error: Illegal package name `linux-image-2.6.24.4-yee~' > make[1]: *** [debian/linux-image-2.6.24.4-yee~] Error 255 I'm fairly sure rpm doesn't allow this too. -- Lubomir Kundrak (Red Hat Security Response Team)