From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JmsKY-0004bw-NG for mharc-grub-devel@gnu.org; Fri, 18 Apr 2008 11:16:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmsKW-0004bZ-Ld for grub-devel@gnu.org; Fri, 18 Apr 2008 11:16:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmsKU-0004Zx-8U for grub-devel@gnu.org; Fri, 18 Apr 2008 11:16:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmsKU-0004Zo-15 for grub-devel@gnu.org; Fri, 18 Apr 2008 11:16:46 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JmsKU-0006xU-35 for grub-devel@gnu.org; Fri, 18 Apr 2008 11:16:46 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 18 Apr 2008 11:16:44 -0400 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 41007619058 for ; Fri, 18 Apr 2008 11:16:44 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080418121356.GA27967@thorin> References: <1208212240.3971.48.camel@localhost.localdomain> <20080415133805.GG21548@thorin> <1208433201.770.43.camel@localhost.localdomain> <20080417201107.GB13794@thorin> <20080417222114.reel0vq6f40gsskc@webmail.spamcop.net> <20080418113259.GD26239@thorin> <20080418121356.GA27967@thorin> Content-Type: text/plain Date: Fri, 18 Apr 2008 11:16:43 -0400 Message-Id: <1208531803.12403.13.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-4.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Make gdb debugging a bit less painful X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2008 15:16:48 -0000 On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote: > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote: > > - jmp EXT_C(cmain) > > + jmp EXT_C(grub_main) > > Or maybe that should be a "call" instead.. Only if there is any chance of return, and we can handle it. "exit" in open firmware based systems would probably mean returning control to open firmware. By the way, it would be nice to have "exit" in both grub for PC and grub-emu, and not only in the rescue mode. "exit" on PC means returning control to BIOS so it can try another boot device. "exit" in grub-emu means exit, of course. I have to use "reboot" now (which should not exit, but rather restart grub-emu, if it belongs to grub-emu at all) or "rescue" followed by "exit". -- Regards, Pavel Roskin