From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763305AbYDTKqx (ORCPT ); Sun, 20 Apr 2008 06:46:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755897AbYDTKkl (ORCPT ); Sun, 20 Apr 2008 06:40:41 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:56320 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbYDTKkj (ORCPT ); Sun, 20 Apr 2008 06:40:39 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Alan Stern , "Rafael J. Wysocki" , Greg Kroah-Hartman Subject: [PATCH 21/36] PM: Fix misuse of wakeup flag accessors in serial core Date: Sun, 20 Apr 2008 03:45:51 -0700 Message-Id: <1208688366-9252-21-git-send-email-gregkh@suse.de> X-Mailer: git-send-email 1.5.4.5 In-Reply-To: <20080420104516.GA9225@suse.de> References: <20080420104516.GA9225@suse.de> X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Stern This patch (as1059) fixes a mistake in the way the serial core initializes a device's wakeup settings. It should use the accessor routine instead of relying on a macro producing an lvalue. Signed-off-by: Alan Stern Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/serial/serial_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c index c32c1ca..a9ca03e 100644 --- a/drivers/serial/serial_core.c +++ b/drivers/serial/serial_core.c @@ -2422,7 +2422,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *port) */ tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev); if (likely(!IS_ERR(tty_dev))) { - device_can_wakeup(tty_dev) = 1; + device_init_wakeup(tty_dev, 1); device_set_wakeup_enable(tty_dev, 0); } else printk(KERN_ERR "Cannot register tty device on line %d\n", -- 1.5.4.5