From: Harvey Harrison <harvey.harrison@gmail.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: simplify code in util.c
Date: Sun, 20 Apr 2008 22:50:54 -0700 [thread overview]
Message-ID: <1208757054.7941.18.camel@brick> (raw)
In-Reply-To: <1208755440.2595.7.camel@debian.sh.intel.com>
On Mon, 2008-04-21 at 13:24 +0800, Zhu Yi wrote:
> On Sun, 2008-04-20 at 19:36 -0700, Harvey Harrison wrote:
> > - hdrlen += (fc & IEEE80211_STYPE_QOS_DATA)
> > - >> (ilog2(IEEE80211_STYPE_QOS_DATA)-1);
> > + if (fc & IEEE80211_STYPE_QOS_DATA)
> > + hdrlen += 2;
>
> You need also take other QoS types (i.e QOS_NULLFUNC) into
> consideration. Please take a look at WLAN_FC_IS_QOS_DATA macro.
>
Well, that would be a change from what's there now, I've just got a
few pure cleanup patches I've done while making some changes in wpa.c
I'm going to submit the cleanup patches on their own first, then
patches with more substance.
Cheers,
Harvey
next prev parent reply other threads:[~2008-04-21 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 2:36 [PATCH] mac80211: simplify code in util.c Harvey Harrison
2008-04-21 5:24 ` Zhu Yi
2008-04-21 5:50 ` Harvey Harrison [this message]
2008-04-21 8:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208757054.7941.18.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.