Re: [PATCH 2.6.26?] Raise the upper limit of NR_CPUS.

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On Mon, 2008-04-21 at 12:03 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2008-04-18 at 15:33 +1000, Tony Breeds wrote:
> > As the pacas are statically initialised increasing NR_CPUS beyond 128,
> > means that any additional pacas will be empty  ... which is bad.
> > 
> > This patch adds the required functionality to fill in any excess pacas
> > at runtime.
> > 
> > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> > ---
> > I know it's late, but can this be considered for 2.6.26?
> 
> NAK.

Tony, you should NAK Ben tomorrow after lunch if you know what I mean :)

> You must NEVER manipulate kernel globals from prom_init.c. The fact that
> prom_init is linked with the kernel is an "accident" which may change.

A very long running accident, we should really look at fixing it some
time.

> Your scheme would break among others with kexec or non-OF bootloaders

I talked to Tony about it this morning and we came up with a scheme that
should work for all cases.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]