From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
Date: Tue, 22 Apr 2008 07:16:31 +1000 [thread overview]
Message-ID: <1208812591.9640.45.camel@pasglop> (raw)
In-Reply-To: <1208789670-28909-1-git-send-email-sr@denx.de>
On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote:
> --------------
> - As suggested by Benjamin Herrenschmidt, don't determine endpoint mode
> by looking at the already configured PCIe port state, but evaluate
> the device_type property instead. This makes it possible for boards
> without a previously run PCIe configuration (e.g. U-Boot) to configure
> a port as endpoint as well.
>
> - Don't map the big external config space upon endpoint configuration.
>
> - Introduce "vendor-id" and "device-id" properties to be written to
> the host bridge.
and class-code too ?
Appart from that, I'll have a quick look at the patch later today but at
first it looks good.
Cheers,
Ben.
next prev parent reply other threads:[~2008-04-21 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 14:54 [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver Stefan Roese
2008-04-21 21:16 ` Benjamin Herrenschmidt [this message]
2008-04-22 5:17 ` Stefan Roese
2008-04-25 6:24 ` Benjamin Herrenschmidt
2008-04-25 10:37 ` Josh Boyer
2008-04-25 12:58 ` Benjamin Herrenschmidt
2008-04-25 13:19 ` Josh Boyer
2008-04-25 13:47 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208812591.9640.45.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.