From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs
Date: Tue, 22 Apr 2008 08:12:24 +1000 [thread overview]
Message-ID: <1208815944.9640.49.camel@pasglop> (raw)
In-Reply-To: <059AA568-4729-4060-A876-C8460E0A7794@kernel.crashing.org>
On Mon, 2008-04-21 at 17:04 -0500, Kumar Gala wrote:
> On Apr 21, 2008, at 4:22 PM, Benjamin Herrenschmidt wrote:
> >
> >>
> >> _GLOBAL(__setup_cpu_603)
> >> - b setup_common_caches
> >> + mflr r4
> >> +BEGIN_FTR_SECTION
> >> + bl __init_fpu_registers
> >> +END_FTR_SECTION_IFCLR(CPU_FTR_FPU_UNAVAILABLE)
> >> + bl __init_fpu_registers
> >> + bl setup_common_caches
> >> + mtlr r4
> >> + blr
> >> _GLOBAL(__setup_cpu_604)
> >> mflr r4
> >> bl setup_common_cache
> >
> > Has the feature fixup been perform yet when __setup_* is called ?
>
> Yes. We call do_feature_fixups() in early_init and call
> call_setup_cpu() after than on 6xx (in head_32.S).
Hrm. I think that may be the other way around on 64 bits... damn, I need
to consolidate these.
I'd rather have the init code explicitely test for the features.
Ben.
next prev parent reply other threads:[~2008-04-21 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 19:57 [PATCH] [POWERPC] ppc32: Fix errata for 603 CPUs Kumar Gala
2008-04-21 20:19 ` Gabriel Paubert
2008-04-21 20:25 ` Kumar Gala
2008-04-21 21:22 ` Benjamin Herrenschmidt
2008-04-21 22:04 ` Kumar Gala
2008-04-21 22:12 ` Benjamin Herrenschmidt [this message]
2008-04-21 22:31 ` Kumar Gala
2008-04-21 22:39 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208815944.9640.49.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.