From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs Date: Wed, 23 Apr 2008 08:20:06 +1000 Message-ID: <1208902806.9640.136.camel@pasglop> References: <20080422012726.42775DE2A3@ozlabs.org> <480E07BC.3050107@ru.mvista.com> Reply-To: benh@kernel.crashing.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JoQqa-00011W-VO for linux-fbdev-devel@lists.sourceforge.net; Tue, 22 Apr 2008 15:20:21 -0700 Received: from gate.crashing.org ([63.228.1.57] ident=[U2FsdGVkX1944VYmPxfdVZUx9USyELJxDZXkKH+qkLw=]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JoQqZ-0006uZ-Gr for linux-fbdev-devel@lists.sourceforge.net; Tue, 22 Apr 2008 15:20:20 -0700 In-Reply-To: <480E07BC.3050107@ru.mvista.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Sergei Shtylyov Cc: linuxppc-dev@ozlabs.org, Andrew Morton , linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, adaplas@gmail.com On Tue, 2008-04-22 at 19:43 +0400, Sergei Shtylyov wrote: > Not sure what that change gives us -- this function mostly treats 'addr' > as unsigned long (casting it to char/void *), ot compares it to 'unsigned > long' 'base' variable -- which should be made 'resource_size_t' in its turn > being assigned resource's start value. So, this part of patch looks incomplete > (and yet I'm not sure if SPARC really needs all that)... I just wanted to make sure both setup functions has the same prototype. I think sparc doesn't need fixing in there. Ben. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7B254DE084 for ; Wed, 23 Apr 2008 08:20:24 +1000 (EST) Subject: Re: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs From: Benjamin Herrenschmidt To: Sergei Shtylyov In-Reply-To: <480E07BC.3050107@ru.mvista.com> References: <20080422012726.42775DE2A3@ozlabs.org> <480E07BC.3050107@ru.mvista.com> Content-Type: text/plain Date: Wed, 23 Apr 2008 08:20:06 +1000 Message-Id: <1208902806.9640.136.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Andrew Morton , linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, adaplas@gmail.com Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2008-04-22 at 19:43 +0400, Sergei Shtylyov wrote: > Not sure what that change gives us -- this function mostly treats 'addr' > as unsigned long (casting it to char/void *), ot compares it to 'unsigned > long' 'base' variable -- which should be made 'resource_size_t' in its turn > being assigned resource's start value. So, this part of patch looks incomplete > (and yet I'm not sure if SPARC really needs all that)... I just wanted to make sure both setup functions has the same prototype. I think sparc doesn't need fixing in there. Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759683AbYDVW0f (ORCPT ); Tue, 22 Apr 2008 18:26:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762957AbYDVWZT (ORCPT ); Tue, 22 Apr 2008 18:25:19 -0400 Received: from gate.crashing.org ([63.228.1.57]:37788 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762792AbYDVWZR (ORCPT ); Tue, 22 Apr 2008 18:25:17 -0400 Subject: Re: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Sergei Shtylyov Cc: linux-fbdev-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org, Andrew Morton , linux-kernel@vger.kernel.org, adaplas@gmail.com In-Reply-To: <480E07BC.3050107@ru.mvista.com> References: <20080422012726.42775DE2A3@ozlabs.org> <480E07BC.3050107@ru.mvista.com> Content-Type: text/plain Date: Wed, 23 Apr 2008 08:20:06 +1000 Message-Id: <1208902806.9640.136.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2008-04-22 at 19:43 +0400, Sergei Shtylyov wrote: > Not sure what that change gives us -- this function mostly treats 'addr' > as unsigned long (casting it to char/void *), ot compares it to 'unsigned > long' 'base' variable -- which should be made 'resource_size_t' in its turn > being assigned resource's start value. So, this part of patch looks incomplete > (and yet I'm not sure if SPARC really needs all that)... I just wanted to make sure both setup functions has the same prototype. I think sparc doesn't need fixing in there. Ben.