From: Priit Laes <plaes@plaes.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jack Steiner <steiner@sgi.com>
Subject: Re: [REGRESSION] x86: support for new UV apic
Date: Fri, 25 Apr 2008 18:53:02 +0300 [thread overview]
Message-ID: <1209138782.6899.0.camel@localhost> (raw)
In-Reply-To: <87abjixo7d.fsf@basil.nowhere.org>
Ühel kenal päeval, R, 2008-04-25 kell 11:45, kirjutas Andi Kleen:
> Ingo Molnar <mingo@elte.hu> writes:
>
> > * Priit Laes <plaes@plaes.org> wrote:
> >
> >> Hey,
> >>
> >> I am getting two following warnings (probable one per each CPU core)
> >> using the latest Linus's git:
> >>
> >> WARNING: at arch/x86/kernel/genapic_64.c:86 read_apic_id+0x30/0x62()
> >> Modules linked in:
> >> Pid: 1, comm: swapper Not tainted 2.6.25-03563-gf7288b1 #20
> >
> > thanks - could you check the patch below, does it fix the warnings?
>
> I think it would have been better to change the WARN_ON to
>
> WARN_ON(preemptible() && num_online_cpus() > 1)
>
> Preemption is actually ok here because this runs before the other
> CPUs are started
>
> Alternative patch appended.
Worksforme :)
--
Priit Laes
next prev parent reply other threads:[~2008-04-25 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 4:43 [REGRESSION] x86: support for new UV apic Priit Laes
2008-04-25 6:44 ` Ingo Molnar
2008-04-25 9:11 ` Gabriel C
2008-04-25 9:19 ` Priit Laes
2008-04-25 9:45 ` Andi Kleen
2008-04-25 11:21 ` Gabriel C
2008-04-25 11:41 ` Gabriel C
2008-04-25 15:53 ` Priit Laes [this message]
2008-04-28 17:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209138782.6899.0.camel@localhost \
--to=plaes@plaes.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.