From: Harvey Harrison <harvey.harrison@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [BUILDFIX PATCH] au0828: debug is a poor global identifier
Date: Fri, 25 Apr 2008 23:14:15 -0700 [thread overview]
Message-ID: <1209190455.14173.13.camel@brick> (raw)
Avoid link-time warnings with debug declared in x86/kernel/entry_32.S
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Otherwise you'll see link time warnings about multiple defintions of
debug. (size 4 here, size 76 in entry_32.S)
drivers/media/video/au0828/au0828-core.c | 14 +++++++-------
drivers/media/video/au0828/au0828.h | 4 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c
index e65d564..9b7a4d7 100644
--- a/drivers/media/video/au0828/au0828-core.c
+++ b/drivers/media/video/au0828/au0828-core.c
@@ -32,9 +32,9 @@
* 4 = I2C related
* 8 = Bridge related
*/
-unsigned int debug;
-module_param(debug, int, 0644);
-MODULE_PARM_DESC(debug, "enable debug messages");
+unsigned int au0828_debug;
+module_param(au0828_debug, int, 0644);
+MODULE_PARM_DESC(au0828_debug, "enable debug messages");
unsigned int usb_debug;
module_param(usb_debug, int, 0644);
@@ -229,23 +229,23 @@ static int __init au0828_init(void)
{
int ret;
- if (debug)
+ if (au0828_debug)
printk(KERN_INFO "%s() Debugging is enabled\n", __func__);
if (usb_debug) {
printk(KERN_INFO "%s() USB Debugging is enabled\n", __func__);
- debug |= 2;
+ au0828_debug |= 2;
}
if (i2c_debug) {
printk(KERN_INFO "%s() I2C Debugging is enabled\n", __func__);
- debug |= 4;
+ au0828_debug |= 4;
}
if (bridge_debug) {
printk(KERN_INFO "%s() Bridge Debugging is enabled\n",
__func__);
- debug |= 8;
+ au0828_debug |= 8;
}
printk(KERN_INFO "au0828 driver loaded\n");
diff --git a/drivers/media/video/au0828/au0828.h b/drivers/media/video/au0828/au0828.h
index 0200b9f..8344c45 100644
--- a/drivers/media/video/au0828/au0828.h
+++ b/drivers/media/video/au0828/au0828.h
@@ -96,7 +96,7 @@ struct au0828_buff {
/* au0828-core.c */
extern u32 au0828_read(struct au0828_dev *dev, u16 reg);
extern u32 au0828_write(struct au0828_dev *dev, u16 reg, u32 val);
-extern unsigned int debug;
+extern unsigned int au0828_debug;
extern unsigned int usb_debug;
extern unsigned int bridge_debug;
@@ -123,6 +123,6 @@ extern int au0828_dvb_register(struct au0828_dev *dev);
extern void au0828_dvb_unregister(struct au0828_dev *dev);
#define dprintk(level, fmt, arg...)\
- do { if (debug & level)\
+ do { if (au0828_debug & level)\
printk(KERN_DEBUG DRIVER_NAME "/0: " fmt, ## arg);\
} while (0)
--
1.5.5.1.270.g89765
next reply other threads:[~2008-04-26 6:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 6:14 Harvey Harrison [this message]
2008-04-26 11:00 ` If you want me to quit I will quit Adrian Bunk
2008-04-26 11:27 ` Sam Ravnborg
2008-04-26 14:44 ` Adrian Bunk
2008-04-26 16:51 ` Linus Torvalds
2008-04-26 17:09 ` Adrian Bunk
2008-04-26 17:21 ` Linus Torvalds
2008-04-26 17:35 ` Adrian Bunk
2008-04-26 17:56 ` Linus Torvalds
2008-04-26 14:51 ` Andrew Morton
2008-04-26 15:23 ` Adrian Bunk
2008-04-26 15:44 ` Andrew Morton
2008-04-26 17:16 ` Adrian Bunk
2008-04-26 17:20 ` Andrew Morton
2008-04-26 17:27 ` Adrian Bunk
2008-04-26 17:35 ` Linus Torvalds
2008-04-26 17:31 ` Linus Torvalds
2008-04-26 17:42 ` Sam Ravnborg
2008-04-26 18:26 ` Linus Torvalds
2008-04-26 18:51 ` Stefan Richter
2008-04-26 19:05 ` Linus Torvalds
2008-04-26 19:18 ` Linus Torvalds
2008-04-26 20:30 ` Andrew Morton
2008-04-26 20:35 ` Linus Torvalds
2008-04-28 19:05 ` Romano Giannetti
2008-04-26 20:49 ` Stefan Richter
2008-04-27 12:07 ` Richard Purdie
2008-04-27 14:28 ` Stefan Richter
2008-04-26 19:43 ` Stefan Richter
2008-04-27 0:31 ` David Miller
2008-04-27 2:58 ` Jeff Garzik
2008-04-27 16:09 ` Ingo Molnar
2008-04-26 16:21 ` Bartlomiej Zolnierkiewicz
2008-04-26 17:10 ` Adrian Bunk
2008-04-26 19:20 ` Harvey Harrison
2008-04-26 19:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209190455.14173.13.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.