From: Harvey Harrison <harvey.harrison@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Sam Ravnborg <sam@ravnborg.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] asm/unaligned.h doesn't work well as the very first include
Date: Sat, 26 Apr 2008 23:31:28 -0700 [thread overview]
Message-ID: <1209277888.14173.45.camel@brick> (raw)
In-Reply-To: <20080427061210.GT5882@ZenIV.linux.org.uk>
On Sun, 2008-04-27 at 07:12 +0100, Al Viro wrote:
> On Sun, Apr 27, 2008 at 08:09:44AM +0200, Sam Ravnborg wrote:
>
> > It has been discussed that any .h file should pull
> > in what it needs so the other of includes does not matter.
> > Some do them alphabetically.
>
> It has been discussed or it has been agreed? IMO it's a bullshit - especially
> for low-level stuff like that.
>
> As for the way some do includes... It's not exactly a family-friendly list,
> but still I'd rather not comment in details on the existing practices...
I'm redoing the unaligned handling in -mm at the moment, and it avoids
this problem.
Harvey
prev parent reply other threads:[~2008-04-27 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 5:19 [PATCH] asm/unaligned.h doesn't work well as the very first include Al Viro
2008-04-27 5:21 ` David Miller
2008-04-27 6:09 ` Sam Ravnborg
2008-04-27 6:12 ` Al Viro
2008-04-27 6:31 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209277888.14173.45.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.