From: Harvey Harrison <harvey.harrison@gmail.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] mac80211: incorrect shift direction
Date: Sun, 27 Apr 2008 10:43:26 -0700 [thread overview]
Message-ID: <1209318206.14173.65.camel@brick> (raw)
In-Reply-To: <1ba2fa240804270800t15c02830p56470fa8996b50d3@mail.gmail.com>
On Sun, 2008-04-27 at 18:00 +0300, Tomas Winkler wrote:
> On Sun, Apr 27, 2008 at 2:24 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Sun, 2008-04-27 at 03:48 -0700, Harvey Harrison wrote:
> > > Looks like 5d2cdcd4e85c5187db30a6b29f79fbbe59f39f78 got the
> > > shifts wrong.
> >
> > Aha! Thanks for tracking this down. We had a patch to fix this but were
> > confused why the bug hadn't been noticed before. So it looks like it
> > wasn't *present* before :)
> >
> What to say.... Shame on me.
> Tomas
This is precisely why I wrote the new unaligned access helpers going in
soon, I'll have this converted at that time.
This line will become:
iv32 = get_unaligned_le32(data + 4);
Harvey
prev parent reply other threads:[~2008-04-27 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 10:48 [PATCH] mac80211: incorrect shift direction Harvey Harrison
2008-04-27 11:24 ` Johannes Berg
2008-04-27 15:00 ` Tomas Winkler
2008-04-27 17:43 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209318206.14173.65.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.